From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#39960: 28.0.50; Incompatible change to sql-add-product in Emacs 27 Date: Fri, 13 Mar 2020 11:53:56 +0200 Message-ID: <83k13o8tsb.fsf@gnu.org> References: <837dzwboes.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="78940"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 39960@debbugs.gnu.org, p.stephani2@gmail.com To: michael@mauger.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 13 10:55:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jCh27-000KIK-G8 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 13 Mar 2020 10:55:11 +0100 Original-Received: from localhost ([::1]:56284 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jCh26-0001KI-IK for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 13 Mar 2020 05:55:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49270) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jCh1z-0001K5-5X for bug-gnu-emacs@gnu.org; Fri, 13 Mar 2020 05:55:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jCh1x-0002wN-V3 for bug-gnu-emacs@gnu.org; Fri, 13 Mar 2020 05:55:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52209) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jCh1x-0002vx-R2 for bug-gnu-emacs@gnu.org; Fri, 13 Mar 2020 05:55:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jCh1x-0003jE-OJ for bug-gnu-emacs@gnu.org; Fri, 13 Mar 2020 05:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Mar 2020 09:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39960 X-GNU-PR-Package: emacs Original-Received: via spool by 39960-submit@debbugs.gnu.org id=B39960.158409324714251 (code B ref 39960); Fri, 13 Mar 2020 09:55:01 +0000 Original-Received: (at 39960) by debbugs.gnu.org; 13 Mar 2020 09:54:07 +0000 Original-Received: from localhost ([127.0.0.1]:58182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jCh14-0003hn-SD for submit@debbugs.gnu.org; Fri, 13 Mar 2020 05:54:07 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33462) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jCh12-0003hG-O8 for 39960@debbugs.gnu.org; Fri, 13 Mar 2020 05:54:04 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:53991) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jCh0x-0001nY-E5; Fri, 13 Mar 2020 05:53:59 -0400 Original-Received: from [176.228.60.248] (port=2647 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jCh0w-0002kI-Id; Fri, 13 Mar 2020 05:53:59 -0400 In-Reply-To: <837dzwboes.fsf@gnu.org> (message from Eli Zaretskii on Sat, 07 Mar 2020 09:43:39 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:177263 Archived-At: Ping! > Date: Sat, 07 Mar 2020 09:43:39 +0200 > From: Eli Zaretskii > Cc: 39960@debbugs.gnu.org > > > From: Philipp > > Date: Fri, 06 Mar 2020 23:39:16 +0100 > > > > > > In Emacs 26, sql-add-product has the signature > > > > (sql-add-product PRODUCT DISPLAY &rest PLIST) > > > > However, in the Emacs 27 pretest the signature is now > > > > (sql-add-product PRODUCT DISPLAY &optional PLIST) > > > > Note the change from &rest to &optional. This is a breaking change that > > breaks all users of sql-add-product. I've found quite a few uses of the > > old signature in the wild, > > e.g. https://github.com/kat-co/sql-prestodb/blob/f4a74d88dcb166445bb41efb865147c0faf1de3a/src/sql-presto.el#L59 > > or > > https://github.com/r0man/vertica-el/blob/3c9647b425c5c13c30bf0cba483646af18196588/vertica.el#L68 > > or > > https://github.com/jterk/sql-impala/blob/466e7c0c789ec3e5e8a276c8f6754f91bb584c3e/sql-impala.el#L71. > > This change was introduced in commit > > c124d5323c05a4010db9b2d330575d029936ade1. I don't think we should > > introduce such a breaking change to a widely-used public function; at > > the very least, Emacs 27 should accept both signatures. > > Thanks for reporting this. > > Michael, could you please look into this ASAP? TIA. > > Btw, this change of a public API is not in NEWS, AFAICT; if we decide > eventually on keeping the change, we should announce it in NEWS. > > > >