unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 25496@debbugs.gnu.org, federicotedin@gmail.com
Subject: bug#25496: 25.1.91; INSIDE_EMACS env variable is not set in eshell
Date: Fri, 03 Apr 2020 15:17:30 +0300	[thread overview]
Message-ID: <83k12wwyp1.fsf@gnu.org> (raw)
In-Reply-To: <87o8sdigl3.fsf@gmail.com> (message from Noam Postavsky on Mon, 30 Mar 2020 19:11:04 -0400)

> From: Noam Postavsky <npostavs@gmail.com>
> Date: Mon, 30 Mar 2020 19:11:04 -0400
> Cc: 25496@debbugs.gnu.org
> 
> > +If the value is a string, the value for the variable with that name in
> > +the current environment will be returned.  If no variable with that
> > +name exists in the environment, but if a symbol with that same name
> > +exists and has a value bound to it, then that value will be used.  You
> > +can prioritize symbol values over environment values by setting
> > +`eshell-prefer-lisp-variables' to t.
> > +
> > +If the value is a symbol, the value bound to that symbol will be used.
> 
> Much better, thanks.

Would it be possible to reword this so that passive tense is used less
frequently?  E.g., instead of "the variable with that name in the
current environment will be returned", how about "return the variable
with that name in the current environment"?  And similarly with the
rest of the doc string.

Thanks.





  parent reply	other threads:[~2020-04-03 12:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-20 22:32 bug#25496: 25.1.91; INSIDE_EMACS env variable is not set in eshell Alex Hutcheson
2017-01-23 20:20 ` Glenn Morris
2017-01-23 20:36   ` Alex Hutcheson
2020-03-08 16:50 ` Federico Tedin
2020-03-28 15:05   ` Federico Tedin
2020-03-29  0:21   ` Noam Postavsky
2020-03-29 22:29     ` Federico Tedin
2020-03-30  1:44       ` Noam Postavsky
2020-03-30 19:52         ` Federico Tedin
2020-03-30 23:11           ` Noam Postavsky
2020-04-02 23:06             ` Noam Postavsky
2020-04-03 12:17             ` Eli Zaretskii [this message]
2020-04-04 10:08               ` Federico Tedin
2020-04-11  9:20                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83k12wwyp1.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=25496@debbugs.gnu.org \
    --cc=federicotedin@gmail.com \
    --cc=npostavs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).