From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#40845: SVG rendering issues Date: Sat, 25 Apr 2020 20:02:53 +0300 Message-ID: <83k1237b2a.fsf@gnu.org> References: <72ebf5eb-6b00-ebb4-dab3-a047e35ae1ae@gmail.com> <83mu6z7em5.fsf@gnu.org> <17307310-2afc-7941-8a48-5cd345d1ad63@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="11779"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 40845@debbugs.gnu.org, pipcet@gmail.com To: =?UTF-8?Q?Cl=C3=A9ment?= Pit-Claudel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 25 19:04:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jSODt-0002yZ-9m for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Apr 2020 19:04:13 +0200 Original-Received: from localhost ([::1]:41226 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jSODs-00037q-93 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Apr 2020 13:04:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38024) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jSODj-00037d-Ef for bug-gnu-emacs@gnu.org; Sat, 25 Apr 2020 13:04:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jSODj-0000Cd-1i for bug-gnu-emacs@gnu.org; Sat, 25 Apr 2020 13:04:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48725) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jSODi-0000Ah-Jk for bug-gnu-emacs@gnu.org; Sat, 25 Apr 2020 13:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jSODi-0007nA-FP for bug-gnu-emacs@gnu.org; Sat, 25 Apr 2020 13:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Apr 2020 17:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40845 X-GNU-PR-Package: emacs Original-Received: via spool by 40845-submit@debbugs.gnu.org id=B40845.158783419229894 (code B ref 40845); Sat, 25 Apr 2020 17:04:02 +0000 Original-Received: (at 40845) by debbugs.gnu.org; 25 Apr 2020 17:03:12 +0000 Original-Received: from localhost ([127.0.0.1]:60271 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSOCt-0007m5-N7 for submit@debbugs.gnu.org; Sat, 25 Apr 2020 13:03:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34800) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSOCs-0007ls-3N for 40845@debbugs.gnu.org; Sat, 25 Apr 2020 13:03:10 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:57905) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jSOCm-000672-Pw; Sat, 25 Apr 2020 13:03:04 -0400 Original-Received: from [176.228.60.248] (port=2702 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jSOCl-00065t-Om; Sat, 25 Apr 2020 13:03:04 -0400 In-Reply-To: <17307310-2afc-7941-8a48-5cd345d1ad63@gmail.com> (message from =?UTF-8?Q?Cl=C3=A9ment?= Pit-Claudel on Sat, 25 Apr 2020 12:42:07 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:179015 Archived-At: > Cc: 40845@debbugs.gnu.org > From: Clément Pit-Claudel > Date: Sat, 25 Apr 2020 12:42:07 -0400 > > >>> 3. The SVG images don't inherit the foreground of the current face; instead, they use a black foreground. > >> > >> Also, IIRC, 3 is an rsvg issue. > > > > I don't think I understand what item 3 is complaining about. If I > > visit etc/images/splash.svg, it gets the background color of the > > default face. So is the complaint that it takes the background from > > the default face instead of the current face? That should be easy to > > fix, I think, as this code in svg_load_image shows: > > That's item 2: > > 2. The SVG images don't inherit the background of the current face; instead, they inherit the background of the default face. > > and you summarized it exactly right. Item 3 is about the color of the circle that the repro draws. . It should be purple, but it's black. Ah, sorry. But IMO the foreground of an image shouldn't be affected by the current face's foreground. Images should come with their own colors, and be displayed like that. I think in the context of the discussion that led to this bug report it's actually almost a must: we want images with attractive colors to serve as the icons, we don't want them to be affected by whatever face happens to be nearby.