From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#41372: 28.0.50; [PATCH] Wrong value of tab-bar-tab-name-ellipsis Date: Sun, 24 May 2020 05:33:59 +0300 Message-ID: <83k112xdrc.fsf@gnu.org> References: <87imguchpw.fsf@gmail.com> <87tv0b7dtf.fsf@mail.linkov.net> <87d06umnq1.fsf@gmail.com> <87pnauuw03.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="16602"; mail-complaints-to="usenet@ciao.gmane.io" Cc: orontee@gmail.com, 41372@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 24 04:34:20 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jcgSy-0004EW-A3 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 24 May 2020 04:34:20 +0200 Original-Received: from localhost ([::1]:57524 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jcgSx-0005Qr-E4 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 May 2020 22:34:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56072) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jcgSh-0005Dt-1o for bug-gnu-emacs@gnu.org; Sat, 23 May 2020 22:34:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52799) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jcgSg-0005BM-P0 for bug-gnu-emacs@gnu.org; Sat, 23 May 2020 22:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jcgSg-0004lV-My for bug-gnu-emacs@gnu.org; Sat, 23 May 2020 22:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 May 2020 02:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41372 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41372-submit@debbugs.gnu.org id=B41372.159028763818300 (code B ref 41372); Sun, 24 May 2020 02:34:02 +0000 Original-Received: (at 41372) by debbugs.gnu.org; 24 May 2020 02:33:58 +0000 Original-Received: from localhost ([127.0.0.1]:36111 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcgSc-0004l6-ED for submit@debbugs.gnu.org; Sat, 23 May 2020 22:33:58 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48632) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcgSa-0004ku-KH for 41372@debbugs.gnu.org; Sat, 23 May 2020 22:33:56 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:53841) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jcgSV-0005Ad-1t; Sat, 23 May 2020 22:33:51 -0400 Original-Received: from [176.228.60.248] (port=4311 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jcgST-00027o-VL; Sat, 23 May 2020 22:33:50 -0400 In-Reply-To: <87pnauuw03.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 24 May 2020 01:28:12 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:180873 Archived-At: > From: Juri Linkov > Date: Sun, 24 May 2020 01:28:12 +0300 > Cc: 41372@debbugs.gnu.org > > >> Thanks for the patch. One problem is that the patch hard-codes the > >> ellipsis, so that the user loses the ability to configure it. > >> A better way would be to leave defvar tab-bar-tab-name-ellipsis, > >> but by default set its value to nil. So when it's non-nil, then use its > >> value, otherwise use "…"/"..." by default. > > > > You're right. Here's un updated patch: > > Eli, this patch should go to emacs-27? I'm okay with doing that on emacs-27, yes. Thanks.