From: Eli Zaretskii <eliz@gnu.org>
To: Philipp Stephani <p.stephani2@gmail.com>
Cc: egh@e6h.org, 42113@debbugs.gnu.org
Subject: bug#42113: 28.0.50; Segmentation fault in json-parse-file
Date: Mon, 29 Jun 2020 17:56:26 +0300 [thread overview]
Message-ID: <83k0zp2a5h.fsf@gnu.org> (raw)
In-Reply-To: <CAArVCkQg6qOSxUVUtgORa7yfgt4w2eg3z1saZP0w_=OVO=Ojwg@mail.gmail.com> (message from Philipp Stephani on Mon, 29 Jun 2020 12:07:33 +0200)
> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Mon, 29 Jun 2020 12:07:33 +0200
> Cc: bug-gnu-emacs@gnu.org, Erik Hetzner <egh@e6h.org>, 42113@debbugs.gnu.org
>
> > > The JSON functions are missing CHECK_STRING in several places where
> > > json_encode is called.
> >
> > In this specific case I think the test is there, but it is done a bit too late. The call to check_string_without_embedded_nuls should be moved before json_encode.
>
> Is that always guaranteed to be correct though? Is there a guarantee
> that encoding can never produce null bytes that weren't already
> present in the input?
It is true that you could in principle write a coding-system that
would produce null bytes (although it wouldn't be very useful). But
in this case we are not talking about any arbitrary coding-system, we
are talking specifically about UTF-8.
next prev parent reply other threads:[~2020-06-29 14:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-28 21:52 bug#42113: 28.0.50; Segmentation fault in json-parse-file Erik Hetzner
2020-06-28 22:29 ` Erik Hetzner
2020-06-29 8:33 ` Philipp Stephani
2020-06-29 9:39 ` Eli Zaretskii
2020-06-29 10:07 ` Philipp Stephani
2020-06-29 14:56 ` Eli Zaretskii [this message]
2020-06-29 10:37 ` Philipp Stephani
2020-06-29 15:39 ` Erik Hetzner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83k0zp2a5h.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=42113@debbugs.gnu.org \
--cc=egh@e6h.org \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).