From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36597: 27.0.50; rehash hash tables eagerly in pdumper Date: Tue, 11 Aug 2020 17:52:44 +0300 Message-ID: <83k0y544lf.fsf@gnu.org> References: <6a260307-a463-bd08-8a10-d7664d0606a2@cs.ucla.edu> <74235afc-7043-1da7-7c71-07f0ca23b9fd@cs.ucla.edu> <83r26mv53z.fsf@gnu.org> <87ft8vbow1.fsf@gnus.org> <87v9hq4ppp.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17473"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 36597-done@debbugs.gnu.org, pipcet@gmail.com To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 11 16:54:15 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5VfJ-0004PM-7Q for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 Aug 2020 16:54:13 +0200 Original-Received: from localhost ([::1]:58144 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k5VfI-0002lr-7y for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 Aug 2020 10:54:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46406) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k5Vf9-0002jr-Pt for bug-gnu-emacs@gnu.org; Tue, 11 Aug 2020 10:54:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58067) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k5Vf9-0006A7-GC for bug-gnu-emacs@gnu.org; Tue, 11 Aug 2020 10:54:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k5Vf8-0004GC-Fv for bug-gnu-emacs@gnu.org; Tue, 11 Aug 2020 10:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Aug 2020 14:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36597 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 36597-done@debbugs.gnu.org id=D36597.159715758616286 (code D ref 36597); Tue, 11 Aug 2020 14:54:02 +0000 Original-Received: (at 36597-done) by debbugs.gnu.org; 11 Aug 2020 14:53:06 +0000 Original-Received: from localhost ([127.0.0.1]:41376 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5VeE-0004Eb-CU for submit@debbugs.gnu.org; Tue, 11 Aug 2020 10:53:06 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35952) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5VeC-0004E3-LF for 36597-done@debbugs.gnu.org; Tue, 11 Aug 2020 10:53:05 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:43562) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k5Ve5-00063T-10; Tue, 11 Aug 2020 10:52:57 -0400 Original-Received: from [176.228.60.248] (port=2048 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k5Ve4-00059J-CT; Tue, 11 Aug 2020 10:52:56 -0400 In-Reply-To: (message from Paul Eggert on Tue, 11 Aug 2020 02:33:34 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:184661 Archived-At: > Cc: Eli Zaretskii , 36597-done@debbugs.gnu.org > From: Paul Eggert > Date: Tue, 11 Aug 2020 02:33:34 -0700 > > It also simplifies the code a bit, so I took the liberty of installing it It doesn't compile here: pdumper.c: In function 'dump_queue_enqueue': pdumper.c:1012:19: warning: unknown conversion type character 'l' in format [-Wformat=] 1012 | dump_trace ("new object %0*"pI"x weight=%d\n", EMACS_INT_XDIGITS, uobj, | ^~~~~~~~~~~~~~~~ In file included from character.h:27, from buffer.h:27, from pdumper.c:34: lisp.h:108:17: note: format string is defined here 108 | # define pI "ll" | ^ pdumper.c:1012:19: warning: format '%d' expects argument of type 'int', but argument 3 has type 'EMACS_UINT' {aka 'long long unsigned int'} [-Wformat=] 1012 | dump_trace ("new object %0*"pI"x weight=%d\n", EMACS_INT_XDIGITS, uobj, | ^~~~~~~~~~~~~~~~ ~~~~ | | | EMACS_UINT {aka long long unsigned int} pdumper.c:1012:48: note: format string is defined here 1012 | dump_trace ("new object %0*"pI"x weight=%d\n", EMACS_INT_XDIGITS, uobj, | ~^ | | | int | %I64d pdumper.c:1012:19: warning: too many arguments for format [-Wformat-extra-args] 1012 | dump_trace ("new object %0*"pI"x weight=%d\n", EMACS_INT_XDIGITS, uobj, | ^~~~~~~~~~~~~~~~ pdumper.c: In function 'dump_queue_dequeue': pdumper.c:1229:6: warning: format '%d' expects argument of type 'int', but argument 3 has type 'gl_intptr_t' {aka 'long int'} [-Wformat=] 1229 | (("dump_queue_dequeue basis=%"PRIdDUMP_OFF" fancy=%"PRIdPTR | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1230 | " zero=%"PRIdPTR" normal=%"PRIdPTR" strong=%"PRIdPTR" hash=%td\n"), | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1231 | basis, 1232 | dump_tailq_length (&dump_queue->fancy_weight_objects), | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | gl_intptr_t {aka long int} pdumper.c:1229:6: warning: format '%d' expects argument of type 'int', but argument 4 has type 'gl_intptr_t' {aka 'long int'} [-Wformat=] pdumper.c:1229:6: warning: format '%d' expects argument of type 'int', but argument 5 has type 'gl_intptr_t' {aka 'long int'} [-Wformat=] pdumper.c:1229:6: warning: format '%d' expects argument of type 'int', but argument 6 has type 'gl_intptr_t' {aka 'long int'} [-Wformat=] pdumper.c:1229:6: warning: unknown conversion type character 't' in format [-Wformat=] pdumper.c:1229:6: warning: too many arguments for format [-Wformat-extra-args] pdumper.c:1310:15: warning: unknown conversion type character 'l' in format [-Wformat=] 1310 | dump_trace (" result score=%f src=%s object=%0*"pI"x\n", | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from character.h:27, from buffer.h:27, from pdumper.c:34: lisp.h:108:17: note: format string is defined here 108 | # define pI "ll" | ^ pdumper.c:1310:15: warning: too many arguments for format [-Wformat-extra-args] 1310 | dump_trace (" result score=%f src=%s object=%0*"pI"x\n", | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ pdumper.c: In function 'hash_table_thaw': pdumper.c:2667:30: error: conversion from 'EMACS_INT' {aka 'long long int'} to 'ptrdiff_t' {aka 'int'} may change value [-Werror=conversion] 2667 | h->hash = make_nil_vector (XFIXNUM (h->hash)); | ^~~~~~~~~~~~~~~~~ cc1.exe: some warnings being treated as errors Makefile:401: recipe for target `pdumper.o' failed make[1]: *** [pdumper.o] Error 1