From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#43195: [PATCH] Remove definitions of UP, BC and PC which should be provided by terminfo Date: Sat, 12 Sep 2020 10:49:05 +0300 Message-ID: <83k0wze8pa.fsf@gnu.org> References: <20200904005748.1538513-1-maskray@google.com> <83wo1at2lu.fsf@gnu.org> <20200904153803.esenh3j2af4ymyd7@google.com> <83lfhfea23.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30874"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 43195-done@debbugs.gnu.org To: =?UTF-8?Q?F=C4=81ng-ru=C3=AC_?= =?UTF-8?Q?S=C3=B2ng?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 12 09:51:00 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kH0JI-0007w2-S3 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 12 Sep 2020 09:51:00 +0200 Original-Received: from localhost ([::1]:46156 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kH0JH-0007q6-T1 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 12 Sep 2020 03:50:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38106) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kH0IM-000737-Bf for bug-gnu-emacs@gnu.org; Sat, 12 Sep 2020 03:50:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34614) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kH0IM-0005ZP-14 for bug-gnu-emacs@gnu.org; Sat, 12 Sep 2020 03:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kH0IL-0001pq-W2 for bug-gnu-emacs@gnu.org; Sat, 12 Sep 2020 03:50:01 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Sep 2020 07:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 43195 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 43195@debbugs.gnu.org, eliz@gnu.org, maskray@google.com Original-Received: via spool by 43195-done@debbugs.gnu.org id=D43195.15998969586992 (code D ref 43195); Sat, 12 Sep 2020 07:50:01 +0000 Original-Received: (at 43195-done) by debbugs.gnu.org; 12 Sep 2020 07:49:18 +0000 Original-Received: from localhost ([127.0.0.1]:46159 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kH0Hd-0001oi-QX for submit@debbugs.gnu.org; Sat, 12 Sep 2020 03:49:18 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33978) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kH0Ha-0001oR-Dn for 43195-done@debbugs.gnu.org; Sat, 12 Sep 2020 03:49:16 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59372) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kH0HV-0005Uu-3Q; Sat, 12 Sep 2020 03:49:09 -0400 Original-Received: from [176.228.60.248] (port=1692 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kH0HT-0005V8-Vh; Sat, 12 Sep 2020 03:49:08 -0400 In-Reply-To: (message from =?UTF-8?Q?F=C4=81ng-ru=C3=AC_?= =?UTF-8?Q?S=C3=B2ng?= on Sat, 12 Sep 2020 00:33:27 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187883 Archived-At: > From: Fāng-ruì Sòng > Date: Sat, 12 Sep 2020 00:33:27 -0700 > Cc: 43195@debbugs.gnu.org > > > > I don't know whether it is worth mentioning that -fcommon/-fno-common does not > > > cause a linker error when libtinfo.so is linked (a common/regular definition > > > preempts a shared definition). > > > > > > -fno-common + libtinfo.a => multiple definition error > > > > OK, but the change works even in these other cases, right? > > Yep! The new code should work in other cases, -fcommon/-fno-common x > libtinfo.a/libtinfo.so OK, so I'm closing the bug report. Thanks.