From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#44611: Prefix arg for xref-goto-xref Date: Thu, 24 Dec 2020 22:44:55 +0200 Message-ID: <83k0t7ndbs.fsf@gnu.org> References: <87k0up68e4.fsf@mail.linkov.net> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> <87k0tab3y0.fsf@mail.linkov.net> <83pn31rg5a.fsf@gnu.org> <877dp9ycq6.fsf@mail.linkov.net> <837dp8r250.fsf@gnu.org> <4a0c8870-e2e7-97c7-5808-afa704ebee13@yandex.ru> <83mty4pj0u.fsf@gnu.org> <1d9bf365-224f-bb41-d79c-e22d110b41e3@yandex.ru> <83eejgpbs8.fsf@gnu.org> <9fa9d286-4497-baa9-15cd-1ef31651781f@yandex.ru> <83a6u4p8nz.fsf@gnu.org> <3c740ee3-cc1c-e2e3-d540-7be0b37d91ef@yandex.ru> <83pn2znloa.fsf@gnu.org> <87pn2zlzy3.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12000"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dgutov@yandex.ru, joaotavora@gmail.com, 44611@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 24 21:46:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ksXUw-00030A-Bx for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Dec 2020 21:46:10 +0100 Original-Received: from localhost ([::1]:36230 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ksXUv-0001nF-Ac for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Dec 2020 15:46:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46280) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ksXUp-0001mh-Bk for bug-gnu-emacs@gnu.org; Thu, 24 Dec 2020 15:46:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44549) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ksXUo-0001T4-IX for bug-gnu-emacs@gnu.org; Thu, 24 Dec 2020 15:46:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ksXUo-0008VP-GH for bug-gnu-emacs@gnu.org; Thu, 24 Dec 2020 15:46:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Dec 2020 20:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44611 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 44611-submit@debbugs.gnu.org id=B44611.160884272932649 (code B ref 44611); Thu, 24 Dec 2020 20:46:02 +0000 Original-Received: (at 44611) by debbugs.gnu.org; 24 Dec 2020 20:45:29 +0000 Original-Received: from localhost ([127.0.0.1]:56095 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksXUH-0008UW-1p for submit@debbugs.gnu.org; Thu, 24 Dec 2020 15:45:29 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:52990) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ksXUC-0008UH-VX for 44611@debbugs.gnu.org; Thu, 24 Dec 2020 15:45:28 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:46341) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ksXU6-00019b-D5; Thu, 24 Dec 2020 15:45:18 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3053 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ksXU5-00058I-Mx; Thu, 24 Dec 2020 15:45:18 -0500 In-Reply-To: <87pn2zlzy3.fsf@mail.linkov.net> (message from Juri Linkov on Thu, 24 Dec 2020 22:19:16 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:196662 Archived-At: > From: Juri Linkov > Cc: Dmitry Gutov , joaotavora@gmail.com, > 44611@debbugs.gnu.org > Date: Thu, 24 Dec 2020 22:19:16 +0200 > > With further development of the search commands based on xref, more > users perceive it as a grep replacement, that however is not based > on grep mode, so this is a good reason to make xref keybindings more > compatible with grep mode. You didn't answer my question why not use the format we use in *grep* buffers or *occur* buffers. > > Given the single precedent I found, I'm fine with declaring the > > current binding of TAB obsolete and providing a replacement for it > > ('b'? 'q'?), so that we could replace it in some future version after > > 28, if that is okay with you and Juri. > > Thanks, this is surely okay. So here is the patch that does this. > It binds 'xref-quit-and-goto-xref' to 'C-j' like in icomplete mode: That's not what I meant: I meant to leave the TAB binding for now at what it is now, while declaring it obsolete in NEWS, and provide an alternative for it that will remain when we rebind TAB to another command. But the rebinding of TAB will have to wait until after Emacs 28. That's the meaning of "obsolete": we don't remove it right away, but first warn users to get prepared for a removal in the future. And why C-j? That's LFD, a key more suitable for acting on something at point, not quitting the buffer. Why not 'q' (for "quit") or 'b' (for "bury")?