From: Eli Zaretskii <eliz@gnu.org>
To: 路客 <luke.yx.lee@gmail.com>
Cc: 46586@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#46586: 26.3, 27.1.50; Emacs crash in a backtrace (core) dump (a long standing issue)
Date: Thu, 18 Feb 2021 16:16:23 +0200 [thread overview]
Message-ID: <83k0r55umg.fsf@gnu.org> (raw)
In-Reply-To: <CAA=xLRMqtaA_Xq14QpONqw=2breuNzE762LhK8YvjO+1SsqahA@mail.gmail.com> (message from 路客 on Thu, 18 Feb 2021 09:56:06 +0800)
> From: 路客 <luke.yx.lee@gmail.com>
> Date: Thu, 18 Feb 2021 09:56:06 +0800
> Cc: 46586@debbugs.gnu.org
>
> > It's an infinite recursion in substitute_object_recurse, called by
> > lread--substitute-object-in-subtree.
>
> I see, but why is Emacs 26.0.50 or earlier able to catch this issue?
The related code was refactored since then. (And I'm not sure Emacs
26.0.50 indeed identified the problem correctly, see below. So it
could be just sheer luck that it didn't crash back then.)
> Shouldn't the read() function try to prevent itself from crashing?
It should, so this is a bug.
But how did such a form get originated? It looks like it's indeed
self-referential, and thus is got to trigger infinite recursion:
> (#1=(#("000008964 .gnus.el" 0 18 (r #1#))
> (def #2=#("000008964 .gnus.el" 0 18
> (r
> (#2#
> (def #3=#("000006393 .gnus.el" 0 18
> (r #4=(#3#
> (def
> #("000006393 .gnus.el" 0 18 (r #4#)) "x"))))"x"))))"x")))
The last part references itself: it seems to define a string with a
text property that is the same string.
Stepping through the code in substitute_object_recurse, I see that we
end up recursively expanding this string:
#("000006393 .gnus.el" 0 18 (r (#("000006393 .gnus.el" 0 18 (r #2)) (def #0 "x"))))
Which then yields this:
#("000006393 .gnus.el" 0 18 (r (#0 (def #("000006393 .gnus.el" 0 18 (r #2)) "x"))))
And that again yields
#("000006393 .gnus.el" 0 18 (r (#("000006393 .gnus.el" 0 18 (r #2)) (def #0 "x"))))
Etc. etc., ad nauseam (or, rather, until we exhaust the C run-time
stack and segfault).
Does anyone see how to stop this infinite recursion, except by
counting recursive invocation levels and bailing out at some arbitrary
depth?
next prev parent reply other threads:[~2021-02-18 14:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 10:13 bug#46586: 26.3, 27.1.50; Emacs crash in a backtrace (core) dump (a long standing issue) 路客
2021-02-17 16:04 ` Eli Zaretskii
2021-02-18 1:56 ` 路客
2021-02-18 14:16 ` Eli Zaretskii [this message]
2021-02-18 14:45 ` Andreas Schwab
2021-02-18 15:00 ` Eli Zaretskii
2022-06-17 15:25 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83k0r55umg.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=46586@debbugs.gnu.org \
--cc=luke.yx.lee@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).