From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#43725: 28.0.50; Include feature/native-comp into master Date: Thu, 18 Feb 2021 22:36:34 +0200 Message-ID: <83k0r53ygd.fsf@gnu.org> References: <87wny8xwcc.fsf@gnus.org> <83im9sqk1b.fsf@gnu.org> <83v9drp8va.fsf@gnu.org> <831rdjd95w.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12643"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, monnier@iro.umontreal.ca, 43725@debbugs.gnu.org To: Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 18 21:38:03 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lCq3m-0003Cs-Mq for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Feb 2021 21:38:02 +0100 Original-Received: from localhost ([::1]:59624 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lCq3l-0000Tq-DY for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Feb 2021 15:38:01 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51450) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCq2p-0008Hk-78 for bug-gnu-emacs@gnu.org; Thu, 18 Feb 2021 15:37:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36615) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lCq2o-0001rK-U5 for bug-gnu-emacs@gnu.org; Thu, 18 Feb 2021 15:37:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lCq2o-0002dP-R6 for bug-gnu-emacs@gnu.org; Thu, 18 Feb 2021 15:37:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Feb 2021 20:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43725 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org, larsi@gnus.org, 43725@debbugs.gnu.org, monnier@iro.umontreal.ca Original-Received: via spool by 43725-submit@debbugs.gnu.org id=B43725.161368059110072 (code B ref 43725); Thu, 18 Feb 2021 20:37:02 +0000 Original-Received: (at 43725) by debbugs.gnu.org; 18 Feb 2021 20:36:31 +0000 Original-Received: from localhost ([127.0.0.1]:48158 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lCq2I-0002cJ-LR for submit@debbugs.gnu.org; Thu, 18 Feb 2021 15:36:30 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33474) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lCq2G-0002by-Ri for 43725@debbugs.gnu.org; Thu, 18 Feb 2021 15:36:29 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49821) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lCq2A-0001Xd-OF; Thu, 18 Feb 2021 15:36:23 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3297 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lCq29-0008Le-EK; Thu, 18 Feb 2021 15:36:22 -0500 In-Reply-To: (message from Andrea Corallo on Thu, 18 Feb 2021 20:32:06 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:200285 Archived-At: > From: Andrea Corallo > Cc: Eli Zaretskii , larsi@gnus.org, monnier@iro.umontreal.ca, > 43725@debbugs.gnu.org > Date: Thu, 18 Feb 2021 20:32:06 +0000 > > >> Several comparisons like this one: > >> > >> + if (val != (long) val) > >> > >> are IMO better written as > >> > >> if (val > LONG_MAX || val < LONG_MIN) > > > > Fixed by 72e4a22391 > > I noticed that with the suggested fix applied in configurations where > 'val' can't exceed a long on the positive side GCC (trunk from some time > ago) is complaining emitting the following warning: > > comp.c:1174:22: warning: logical ‘or’ of collectively exhaustive tests is always true [-Wlogical-op] > 1174 | if (val > LONG_MAX || val < LONG_MIN) > | ^~ > > Not sure what's the best way to silence it or if we want to revert to > the previous formulation. You can either condition that by WIDE_EMACS_INT, or add a comparison between LONG_MAX and INT_MAX.