From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#43725: 28.0.50; Include feature/native-comp into master Date: Sun, 14 Mar 2021 21:51:38 +0200 Message-ID: <83k0q9fr91.fsf@gnu.org> References: <83a6s04glg.fsf@gnu.org> <83k0qzv54q.fsf@gnu.org> <83lfawp2cc.fsf@gnu.org> <83k0qgp0hj.fsf@gnu.org> <837dmfp2x7.fsf@gnu.org> <83v99znizq.fsf@gnu.org> <83o8frnf2r.fsf@gnu.org> <83r1khfy5d.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25313"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, monnier@iro.umontreal.ca, 43725@debbugs.gnu.org To: Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 14 20:52:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lLWmX-0006NR-4w for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Mar 2021 20:52:09 +0100 Original-Received: from localhost ([::1]:53544 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lLWmW-0004JW-5G for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Mar 2021 15:52:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40894) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lLWmP-0004Hk-TE for bug-gnu-emacs@gnu.org; Sun, 14 Mar 2021 15:52:01 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50937) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lLWmP-0005pV-KV for bug-gnu-emacs@gnu.org; Sun, 14 Mar 2021 15:52:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lLWmP-0000Pe-IY for bug-gnu-emacs@gnu.org; Sun, 14 Mar 2021 15:52:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Mar 2021 19:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43725 X-GNU-PR-Package: emacs Original-Received: via spool by 43725-submit@debbugs.gnu.org id=B43725.16157514961555 (code B ref 43725); Sun, 14 Mar 2021 19:52:01 +0000 Original-Received: (at 43725) by debbugs.gnu.org; 14 Mar 2021 19:51:36 +0000 Original-Received: from localhost ([127.0.0.1]:34250 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lLWm0-0000Oz-5s for submit@debbugs.gnu.org; Sun, 14 Mar 2021 15:51:36 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51134) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lLWlz-0000Om-4F for 43725@debbugs.gnu.org; Sun, 14 Mar 2021 15:51:35 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58485) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lLWlt-0005aN-CI; Sun, 14 Mar 2021 15:51:29 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1553 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lLWls-00074s-Ow; Sun, 14 Mar 2021 15:51:29 -0400 In-Reply-To: (message from Andrea Corallo on Sun, 14 Mar 2021 19:06:01 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202388 Archived-At: > From: Andrea Corallo > Cc: larsi@gnus.org, monnier@iro.umontreal.ca, 43725@debbugs.gnu.org > Date: Sun, 14 Mar 2021 19:06:01 +0000 > > Probably in this case I thought that because I've used > Ffile_name_as_directory its output could just be concatenated without > having to use Fexpand_file_name. > > Is this practice incorrect or dangerous? It's "not recommended". The reason is that expand-file-name deals with irregularities such as multiple consecutive slashes, unibyte vs multibyte strings, drive letters on MS-Windows, etc., and 'concat' doesn't. I will go over the code and replace 'concat' where needed.