From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#38164: quit-restore-window doesn't restore point in man Date: Sun, 04 Apr 2021 21:28:38 +0300 Message-ID: <83k0phdhux.fsf@gnu.org> References: <8ea0a3fa-5169-4493-bd54-3ebe47836a35@default> <87r3i9nped.fsf@gnus.org> <87wps1m7co.fsf@web.de> <87r22gbquk.fsf@mail.linkov.net> <875zjrzgoz.fsf_-_@mail.linkov.net> <02f0564a-baf3-b15c-bcc5-98d37f510d7a@gmx.at> <877e45ksaz.fsf@mail.linkov.net> <874knrp9ad.fsf@gnus.org> <87zgyd536a.fsf@tcd.ie> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10604"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 38164@debbugs.gnu.org, juri@linkov.net To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 04 20:29:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lT7Uj-0002dK-Ib for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Apr 2021 20:29:09 +0200 Original-Received: from localhost ([::1]:39656 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lT7Ui-0003C6-4W for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Apr 2021 14:29:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53022) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lT7Ub-0003Bz-Uu for bug-gnu-emacs@gnu.org; Sun, 04 Apr 2021 14:29:01 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53123) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lT7Ub-0007nW-Lv for bug-gnu-emacs@gnu.org; Sun, 04 Apr 2021 14:29:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lT7Ub-0005OW-H7 for bug-gnu-emacs@gnu.org; Sun, 04 Apr 2021 14:29:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Apr 2021 18:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38164 X-GNU-PR-Package: emacs Original-Received: via spool by 38164-submit@debbugs.gnu.org id=B38164.161756094020729 (code B ref 38164); Sun, 04 Apr 2021 18:29:01 +0000 Original-Received: (at 38164) by debbugs.gnu.org; 4 Apr 2021 18:29:00 +0000 Original-Received: from localhost ([127.0.0.1]:36436 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lT7UZ-0005OH-NT for submit@debbugs.gnu.org; Sun, 04 Apr 2021 14:29:00 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60006) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lT7UW-0005O1-P0 for 38164@debbugs.gnu.org; Sun, 04 Apr 2021 14:28:58 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44205) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lT7UQ-0007hq-R0; Sun, 04 Apr 2021 14:28:50 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4847 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lT7UQ-0004Kn-4Z; Sun, 04 Apr 2021 14:28:50 -0400 In-Reply-To: <87zgyd536a.fsf@tcd.ie> (contovob@tcd.ie) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203552 Archived-At: > From: "Basil L. Contovounesios" > Date: Sun, 04 Apr 2021 19:13:01 +0100 > Cc: 38164@debbugs.gnu.org, Juri Linkov > > Lars Ingebrigtsen writes: > > > Juri Linkov writes: > > > >> - (quit-restore-window > >> - (get-buffer-window Man-buffer t) 'kill) > >> + (progn > >> + (quit-restore-window > >> + (get-buffer-window Man-buffer t) 'kill) > >> + (select-window (old-selected-window))) > > > > The discussion then dealt mostly with general quit-restore-windows > > issues, but I think this patch should be applied, since it fixes an > > annoying problem in Man. So I've now pushed it to Emacs 28. > > This gives rise to the following regression: > > 0. emacs -Q > 1. (setq Man-notify-method 'aggressive) C-x C-e > 2. M-x man RET mythical RET > > This used to pop up and very quickly hide a window (but that's a > separate issue), and then the echo area displayed: > > Can't find the mythical manpage > > Whereas now the phantom window remains displayed much longer, the echo > area displays: > > error in process sentinel: > Wrong type argument: window-live-p, # > > and the *Messages* buffer also contains: > > error in process sentinel: > Man-bgproc-sentinel: Wrong type argument: window-live-p, # So we traded a minor issue for a more serious one. (And if I try the recipe which triggered that change, I see a perfectly expected behavior in Emacs 24.) I think that change should be reverted.