unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Aaron Jensen <aaronjensen@gmail.com>
Cc: 47860@debbugs.gnu.org, gregory@heytings.org
Subject: bug#47860: 28.0.50; Mini buffer resize when lines are truncated regression
Date: Mon, 19 Apr 2021 17:48:40 +0300	[thread overview]
Message-ID: <83k0oys52v.fsf@gnu.org> (raw)
In-Reply-To: <CAHyO48w7oNMQkd44JJH1y0X+W5VcZizwC4HRE74YSGGnFYxgeg@mail.gmail.com> (message from Aaron Jensen on Mon, 19 Apr 2021 09:02:24 -0500)

> From: Aaron Jensen <aaronjensen@gmail.com>
> Date: Mon, 19 Apr 2021 09:02:24 -0500
> Cc: Gregory Heytings <gregory@heytings.org>, 47860@debbugs.gnu.org
> 
> > IOW, given that the current code does "somewhat" better than
> > everything we had before, what exactly is the problem you (Aaron) see
> > with the offending commit that you call it "regression"?
> 
> I have not tested with Emacs 27.

Not just 27, 27 and all the previous versions.

> I have, however, tested with Emacs 28
> with and without the commit I mentioned.
> 
> With the commit reverted, I see this:
> 
> https://cln.sh/sNpBcb
> 
> Without it reverted, I see this:
> 
> https://cln.sh/RtPEie
> 
> What I expect is for the minibuffer to be sized as the first example
> and not the second.

So you have a package (or two?) that work(s) only with an unreleased
codebase of Emacs 28 before those two commits were installed?  How
do those packages work in Emacs 27 and previous versions?

> This is what it looks like when using selectrum in Emacs 27:
> 
> https://user-images.githubusercontent.com/8199224/114367956-3f4a8e00-9b7d-11eb-8307-5372fb48de63.png
> 
> and Emacs 28:
> 
> https://user-images.githubusercontent.com/8588/114411541-e1fd0f80-9b71-11eb-8ba3-5bf1437a7806.png

That looks like an entirely different phenomenon than the one
presented by the minimal reproducer.  Are you sure that the reproducer
actually shows the same problem?

Bottom line, I'm now even more confused regarding the problem and the
effect of the 2 commits you reverted.  Reverting them should get you
back to what we had in Emacs 27 and before, but you say it doesn't?
And the effect on selectrum is very different than the effect on the
reproducer you posted.





  parent reply	other threads:[~2021-04-19 14:48 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-18  1:31 bug#47860: 28.0.50; Mini buffer resize when lines are truncated regression Aaron Jensen
2021-04-18  6:57 ` Eli Zaretskii
2021-04-18 17:45   ` Aaron Jensen
2021-04-18 18:03     ` Eli Zaretskii
2021-04-19  0:15       ` Aaron Jensen
2021-04-19 12:40         ` Gregory Heytings
2021-04-19 13:10           ` Eli Zaretskii
2021-04-19 14:02             ` Aaron Jensen
2021-04-19 14:24               ` Aaron Jensen
2021-04-19 14:43                 ` Eli Zaretskii
2021-04-19 14:48               ` Eli Zaretskii [this message]
2021-04-19 15:13                 ` Aaron Jensen
2021-04-19 16:19                   ` Aaron Jensen
2021-04-19 17:15                     ` Eli Zaretskii
2021-04-19 17:40                       ` Eli Zaretskii
2021-04-22 11:07                         ` Eli Zaretskii
2021-04-22 16:00                           ` Aaron Jensen
2021-04-22 16:50                             ` Eli Zaretskii
2021-04-19 14:48               ` Gregory Heytings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83k0oys52v.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=47860@debbugs.gnu.org \
    --cc=aaronjensen@gmail.com \
    --cc=gregory@heytings.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).