From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#48072: 28.0.50: dired-read-shell-command: handle empty input properly [PATCH] Date: Wed, 28 Apr 2021 05:22:16 +0300 Message-ID: <83k0ongnc7.fsf@gnu.org> References: <20210427190243.n5yg3gywd5wma3jl@E15-2016.optimum.net> <83lf93h6x1.fsf@gnu.org> <20210427193253.ourhlr3nxdem3e6t@E15-2016.optimum.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9237"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48072@debbugs.gnu.org To: Boruch Baum Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 28 04:23:21 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lbZrF-0002Jp-5E for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 28 Apr 2021 04:23:21 +0200 Original-Received: from localhost ([::1]:41890 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbZrE-0000jY-7O for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 27 Apr 2021 22:23:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41404) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbZqy-0000iq-Js for bug-gnu-emacs@gnu.org; Tue, 27 Apr 2021 22:23:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39821) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lbZqw-0008KD-4S for bug-gnu-emacs@gnu.org; Tue, 27 Apr 2021 22:23:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lbZqv-0007B7-VD for bug-gnu-emacs@gnu.org; Tue, 27 Apr 2021 22:23:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Apr 2021 02:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48072 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 48072-submit@debbugs.gnu.org id=B48072.161957655727536 (code B ref 48072); Wed, 28 Apr 2021 02:23:01 +0000 Original-Received: (at 48072) by debbugs.gnu.org; 28 Apr 2021 02:22:37 +0000 Original-Received: from localhost ([127.0.0.1]:51365 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbZqW-0007A3-O3 for submit@debbugs.gnu.org; Tue, 27 Apr 2021 22:22:36 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33068) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbZqU-00079n-G7 for 48072@debbugs.gnu.org; Tue, 27 Apr 2021 22:22:35 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:35836) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbZqO-00080u-Vu; Tue, 27 Apr 2021 22:22:29 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2078 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lbZqO-0001B1-9G; Tue, 27 Apr 2021 22:22:28 -0400 In-Reply-To: <20210427193253.ourhlr3nxdem3e6t@E15-2016.optimum.net> (message from Boruch Baum on Tue, 27 Apr 2021 15:32:53 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205075 Archived-At: > Date: Tue, 27 Apr 2021 15:32:53 -0400 > From: Boruch Baum > Cc: 48072@debbugs.gnu.org > > > > validates the entered command as a valid shell executable. > > > > This is certainly a mistake: a valid shell command doesn't have to be > > a file that executable-find is able to find. Shells are known to > > support all kinds of internal and magic commands. > > My testing indicates otherwise. Would you care to share the details of that testing, please?