From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#48137: 27.2; `package-install-file' fails when loading a package file with DOS line endings Date: Sat, 29 May 2021 17:09:10 +0300 Message-ID: <83k0nh6395.fsf@gnu.org> References: <83tunj651i.fsf@gnu.org> <83lf8u68bu.fsf@gnu.org> <83mtta4gtf.fsf@gnu.org> <83fsz24f2x.fsf@gnu.org> <83v97x2xum.fsf@gnu.org> <83bl9nevd3.fsf@gnu.org> <831rad5t18.fsf@gnu.org> <835yz26jdk.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8758"; mail-complaints-to="usenet@ciao.gmane.io" Cc: ioannis.kappas@gmail.com, 48137@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 29 16:10:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lmzfH-000268-OB for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 29 May 2021 16:10:11 +0200 Original-Received: from localhost ([::1]:32806 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lmzfG-0003DK-R8 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 29 May 2021 10:10:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46864) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmzf8-0003AZ-Tj for bug-gnu-emacs@gnu.org; Sat, 29 May 2021 10:10:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45939) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lmzf8-0008J3-M3 for bug-gnu-emacs@gnu.org; Sat, 29 May 2021 10:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lmzf8-0005Vy-HD for bug-gnu-emacs@gnu.org; Sat, 29 May 2021 10:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 May 2021 14:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48137 X-GNU-PR-Package: emacs Original-Received: via spool by 48137-submit@debbugs.gnu.org id=B48137.162229734821100 (code B ref 48137); Sat, 29 May 2021 14:10:02 +0000 Original-Received: (at 48137) by debbugs.gnu.org; 29 May 2021 14:09:08 +0000 Original-Received: from localhost ([127.0.0.1]:57477 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmzeG-0005UG-HQ for submit@debbugs.gnu.org; Sat, 29 May 2021 10:09:08 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52822) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmzeE-0005Tl-3n for 48137@debbugs.gnu.org; Sat, 29 May 2021 10:09:07 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:43990) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lmze8-0007e8-Pn; Sat, 29 May 2021 10:09:00 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4173 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmze8-0006oK-Cz; Sat, 29 May 2021 10:09:00 -0400 In-Reply-To: (message from Stefan Monnier on Sat, 29 May 2021 09:59:01 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207535 Archived-At: > From: Stefan Monnier > Cc: Ioannis Kappas , 48137@debbugs.gnu.org > Date: Sat, 29 May 2021 09:59:01 -0400 > > >> Please find below a patch to read package headers from a temporarily > >> decoded buffer, while keeping the literal buffer (which will be used > >> to install the package) intact. > > > > Stefan, any comments? > > No particular comment from me, except: this is tricky enough that > it would benefit from some regression tests. Thanks. Yes, that's a good idea. Ioannis, could you perhaps add some tests, both using existing packages and perhaps also some you concoct just for testing purposes?