From: Eli Zaretskii <eliz@gnu.org>
To: Okam <okamsn@protonmail.com>
Cc: 49120@debbugs.gnu.org
Subject: bug#49120: [PATCH] Add commands 'kill-lines' and 'copy-lines'
Date: Sat, 03 Jul 2021 10:07:00 +0300 [thread overview]
Message-ID: <83k0m7j2p7.fsf@gnu.org> (raw)
In-Reply-To: <091f7b9d-4314-37d2-faf9-9a88134c6b64@protonmail.com> (message from Okam on Thu, 01 Jul 2021 23:50:26 +0000)
> Date: Thu, 01 Jul 2021 23:50:26 +0000
> From: Okam <okamsn@protonmail.com>
> Cc: 49120@debbugs.gnu.org
>
> >> +(defun kill-lines (regexp &optional rstart rend interactive)
> >> + "Kill lines containing matches for REGEXP.
> >> +
> >> +When called from Lisp (and usually when called interactively as
> >> +well, see below), applies to the part of the buffer after point.
> >> +The line point is in is killed if and only if it contains a match
> >> +for regexp starting after point.
> > ^^^^^^
> > REGEXP should in all caps.
> >
> >> +Second and third arg RSTART and REND specify the region to
> > ^^^
> > "args", in plural.
> >
> >> +operate on. Lines partially contained in this region are killed
> >> +if and only if they contain a match entirely contained in it.
> > ^^^^^
> > "in the region" will make this more clear.
> >
> >> + When
> >> +calling this function from Lisp, you can pretend that it was
> >> +called interactively by passing a non-nil INTERACTIVE argument.
> >
> > This is not specific to this command, so why tell it here?
> >
> > Same comments apply to copy-lines.
>
>
> Fixed. Since the documentation string was originally copied from
> `flush-lines`, do you want `keep-lines` and `flush-lines` to also have
> these changes?
Yes. But that should be a separate patch.
The patch LGTM, thanks.
next prev parent reply other threads:[~2021-07-03 7:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-19 17:12 bug#49120: [PATCH] Add commands 'kill-lines' and 'copy-lines' Okam via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-06-19 17:33 ` Eli Zaretskii
2021-07-01 23:50 ` Okam via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-07-03 7:07 ` Eli Zaretskii [this message]
2021-07-20 12:10 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83k0m7j2p7.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=49120@debbugs.gnu.org \
--cc=okamsn@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).