From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#50965: Allow nil third argument for mapconcat Date: Sun, 03 Oct 2021 08:56:23 +0300 Message-ID: <83k0iuaby0.fsf@gnu.org> References: <87v92ftu17.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14480"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 50965@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 03 07:57:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mWuUs-0003aB-Dq for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 03 Oct 2021 07:57:14 +0200 Original-Received: from localhost ([::1]:41396 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mWuUr-0003sn-1C for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 03 Oct 2021 01:57:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55958) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mWuUg-0003sQ-Rw for bug-gnu-emacs@gnu.org; Sun, 03 Oct 2021 01:57:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49342) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mWuUg-0005a6-4t for bug-gnu-emacs@gnu.org; Sun, 03 Oct 2021 01:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mWuUg-00035L-1P for bug-gnu-emacs@gnu.org; Sun, 03 Oct 2021 01:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Oct 2021 05:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50965 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50965-submit@debbugs.gnu.org id=B50965.163324060611833 (code B ref 50965); Sun, 03 Oct 2021 05:57:01 +0000 Original-Received: (at 50965) by debbugs.gnu.org; 3 Oct 2021 05:56:46 +0000 Original-Received: from localhost ([127.0.0.1]:60888 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mWuUP-00034n-OY for submit@debbugs.gnu.org; Sun, 03 Oct 2021 01:56:45 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50810) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mWuUO-00034a-19 for 50965@debbugs.gnu.org; Sun, 03 Oct 2021 01:56:44 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:41136) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mWuUG-0005BZ-RO; Sun, 03 Oct 2021 01:56:38 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2878 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mWuUG-0006gQ-C6; Sun, 03 Oct 2021 01:56:36 -0400 In-Reply-To: (message from Stefan Kangas on Sun, 3 Oct 2021 01:03:54 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:216215 Archived-At: > From: Stefan Kangas > Date: Sun, 3 Oct 2021 01:03:54 +0200 > Cc: 50965@debbugs.gnu.org > > +Optional argument SEPARATOR must be a string, a vector, or a list of > +characters; nil is the empty string." nil is not a string, so saying that is not the best wording. I suggest "nil stands for an empty string." instead. > +Optional argument SEPARATOR must be a string, a vector, or a list of > +characters; nil is the empty string. Likewise. > +(ert-deftest fns-tests-mapconcat () > + (should (string= (mapconcat #'identity '() "_") "")) > + (should (string= (mapconcat #'identity '("A") "_") "A")) > + (should (string= (mapconcat #'identity '("A" "B") "_") "A_B")) > + (should (string= (mapconcat #'identity '("A" "B" "C") "_") "A_B_C")) > + (should (string= (mapconcat #'identity '("a" "b")) "ab"))) Please be sure to test with vectors, bool-vectors, list of characters, and non-ASCII strings as well. > I'm assuming this should go to master at this point. Yes, thanks.