unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: emerick@gmail.com, 1501@debbugs.gnu.org, cyd@stupidchicken.com,
	npostavs@gmail.com
Subject: bug#1501: Emacs 22 loses undo buffer
Date: Wed, 20 Oct 2021 15:05:34 +0300	[thread overview]
Message-ID: <83k0i7c35d.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkmnS-jA9s=J28-KqUNBnxH0HZTyEnrcN0onnOvPQfp79uw@mail.gmail.com> (message from Stefan Kangas on Tue, 19 Oct 2021 18:01:43 -0700)

> From: Stefan Kangas <stefan@marxist.se>
> Date: Tue, 19 Oct 2021 18:01:43 -0700
> Cc: Emerick Rogul <emerick@gmail.com>, 1501@debbugs.gnu.org,
>  Chong Yidong <cyd@stupidchicken.com>
> 
> +  /* Remove the `face' property to save space.  (Bug1501)  */
> +  if (!NILP (string))
> +    Fremove_list_of_text_properties (make_fixnum (0),
> +				     make_fixnum (SCHARS (string)),
> +				     CALLN (Flist, Qface),
> +				     string);

This modifies the text properties of STRING, which you don't own.

Also, it will do unnecessary non-trivial processing when undo is
turned off.

I definitely think that with the enlarged undo-limit we should leave
this obscure situation alone.  It isn't worth making such significant
low-level changes due to such obscure problems, which are arguably
cockpit errors.





  reply	other threads:[~2021-10-20 12:05 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-05 16:51 bug#1501: Emacs 22 loses undo buffer Emerick Rogul
2019-08-20 18:36 ` Stefan Kangas
2019-08-20 18:45   ` Noam Postavsky
2019-08-21 14:46     ` Stefan Kangas
2019-08-22  1:19       ` Noam Postavsky
2021-10-20  1:01         ` Stefan Kangas
2021-10-20 12:05           ` Eli Zaretskii [this message]
2021-10-21 20:46             ` Stefan Kangas
  -- strict thread matches above, loose matches on Subject: below --
2008-12-06  4:01 Chong Yidong
2008-12-06 21:02 Emerick Rogul
2008-12-07  1:31 ` Chong Yidong
2008-12-07  2:03   ` Emerick Rogul
2008-12-07  5:36     ` Chong Yidong
2008-12-07  5:48     ` Chong Yidong
2008-12-07 12:36       ` Emerick Rogul
2009-01-27 20:58 Chong Yidong
2009-04-24 22:14 Suresh Kannan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83k0i7c35d.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=1501@debbugs.gnu.org \
    --cc=cyd@stupidchicken.com \
    --cc=emerick@gmail.com \
    --cc=npostavs@gmail.com \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).