From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#51702: 29.0.50; [PATCH] Fix xwidget buffer name being stuck on something nonsensical Date: Tue, 09 Nov 2021 14:50:19 +0200 Message-ID: <83k0hh5w8k.fsf@gnu.org> References: <87k0hhal3v.fsf.ref@yahoo.com> <87k0hhal3v.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8260"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 51702@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 09 13:51:24 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mkQax-0001nf-8W for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Nov 2021 13:51:23 +0100 Original-Received: from localhost ([::1]:45448 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mkQav-0007iZ-6d for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Nov 2021 07:51:21 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46616) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mkQac-0007hf-NE for bug-gnu-emacs@gnu.org; Tue, 09 Nov 2021 07:51:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49569) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mkQac-000607-Cn for bug-gnu-emacs@gnu.org; Tue, 09 Nov 2021 07:51:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mkQab-00075A-W0 for bug-gnu-emacs@gnu.org; Tue, 09 Nov 2021 07:51:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Nov 2021 12:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51702 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51702-submit@debbugs.gnu.org id=B51702.163646224027196 (code B ref 51702); Tue, 09 Nov 2021 12:51:01 +0000 Original-Received: (at 51702) by debbugs.gnu.org; 9 Nov 2021 12:50:40 +0000 Original-Received: from localhost ([127.0.0.1]:32882 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mkQaF-00074a-Kx for submit@debbugs.gnu.org; Tue, 09 Nov 2021 07:50:39 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45640) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mkQaB-00074I-Ew for 51702@debbugs.gnu.org; Tue, 09 Nov 2021 07:50:38 -0500 Original-Received: from [2001:470:142:3::e] (port=36820 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mkQa2-0005Pi-QQ; Tue, 09 Nov 2021 07:50:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=L8QFsn0GDF1Vt8579806qB8LDKM1jUf1q2u/N3Ezv2c=; b=puWY26HV4X4i 5Z00yf++rFoEwGxw4oF1yaCCPZ4rfrYtD1XKJkMZ6hGldP8slNQA2FQhYa0BRlGzEFui1TT0Ghghl xR1Hwumwrwyuvo9GOxKcM1eoKMCoSuw+4J48QqR6Sz0hYCoqfWt/k2i0y/NBNjqgimEdHZ7sb4jqH TXWlDBr0X6aGwHPXBXJhRdh631rjwJBRByCS0FcnUWICZws9EtyK9CMRmdKxNNM0hfz5QzGOjk2c5 z+naqgHSiLZuNjEMyEF2VlQzaz7QFtix+Ik/TqMPLvytMKAyksft5b378XAehcB15E+E3ki6C3DNU lqVA5MYJpyTjXFOgh+wEFQ==; Original-Received: from [87.69.77.57] (port=3460 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mkQa1-0000HD-MQ; Tue, 09 Nov 2021 07:50:26 -0500 In-Reply-To: <87k0hhal3v.fsf@yahoo.com> (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:219442 Archived-At: > Date: Tue, 09 Nov 2021 14:39:32 +0800 > From: Po Lu via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > >From a943d9b995d701d4ae7029f6f6f3ae91ceb3a29b Mon Sep 17 00:00:00 2001 > From: Po Lu > Date: Tue, 9 Nov 2021 14:37:47 +0800 > Subject: [PATCH] Always set xwidget title if the event was "load-finished" > > * lisp/xwidget.el (xwidget-webkit-callback): Always set title upon > load completion. This prevents loading pages such as "about:blank" > from not setting the buffer name. > --- > lisp/xwidget.el | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/lisp/xwidget.el b/lisp/xwidget.el > index fc37798322..905327083b 100644 > --- a/lisp/xwidget.el > +++ b/lisp/xwidget.el > @@ -360,9 +360,11 @@ xwidget-webkit-callback > (cond ((eq xwidget-event-type 'load-changed) > (let ((title (xwidget-webkit-title xwidget))) > ;; This funciton will be called multi times, so only > - ;; change buffer name when get a valid title. this can > - ;; limit buffer-name flicker in mode-line. > - (when (> (length title) 0) > + ;; change buffer name when the load actually completes > + ;; this can limit buffer-name flicker in mode-line. > + (when (or (string-equal (nth 3 last-input-event) > + "load-finished") > + (> (length title) 0)) You've lost the period in the comment there. And the sentence after that should be capitalized, of course.