From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#51821: 29.0.50; Suggest add variable or frame parameter: line-height Date: Sun, 14 Nov 2021 20:14:06 +0200 Message-ID: <83k0hatxjl.fsf@gnu.org> References: <87bl2nhbyp.fsf@163.com> <83bl2nugao.fsf@gnu.org> <878rxq62qt.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9669"; mail-complaints-to="usenet@ciao.gmane.io" Cc: tumashu@163.com, 51821@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 14 19:15:15 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mmK25-0002EC-Rn for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Nov 2021 19:15:14 +0100 Original-Received: from localhost ([::1]:35452 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mmK23-0007rc-TX for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Nov 2021 13:15:11 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54316) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmK1u-0007rR-FN for bug-gnu-emacs@gnu.org; Sun, 14 Nov 2021 13:15:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40066) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mmK1u-0006Qp-6l for bug-gnu-emacs@gnu.org; Sun, 14 Nov 2021 13:15:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mmK1u-0001HH-0U for bug-gnu-emacs@gnu.org; Sun, 14 Nov 2021 13:15:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Nov 2021 18:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51821 X-GNU-PR-Package: emacs Original-Received: via spool by 51821-submit@debbugs.gnu.org id=B51821.16369136674844 (code B ref 51821); Sun, 14 Nov 2021 18:15:01 +0000 Original-Received: (at 51821) by debbugs.gnu.org; 14 Nov 2021 18:14:27 +0000 Original-Received: from localhost ([127.0.0.1]:51612 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmK1K-0001G4-S8 for submit@debbugs.gnu.org; Sun, 14 Nov 2021 13:14:27 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:53508) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmK1I-0001Fr-K1 for 51821@debbugs.gnu.org; Sun, 14 Nov 2021 13:14:24 -0500 Original-Received: from [2001:470:142:3::e] (port=32974 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmK1D-0006Nh-Dd; Sun, 14 Nov 2021 13:14:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=j/nWfGUQCdk/Ap53Z194Bc7nni7GeTkRBYJKSCT1KwU=; b=NulbZoAc71eG 0CW84ZTQpvKegyBa+nXaWcJ4JS2CHj8gj3hjTuoOkZDLqU+GV3a3Fol4/b3jaHEnc9VdiBKhScbOX rK9kEXs8q4fAoG7opVYoG9vvFPk/FGeJe4h8ghhzfSJGj5ncXTRqWDQb3Be1iCqelQpp8+SgzFocX SEMf39S7CHGSL7kPXrBNh5MFRRdW63TmHanb6zqHNAT/+6IpnWpSNmHI8Di0K1VFWM5A/kBtYc7AG NEjKPvNFDi7ZaeaLOBj0F0nRav9fA9MWv9D5w6uw3sNn9OO1bSqvwBLzxMFP5LjB+gdEgn3vZ65Oe elgDVOT1deDgPkVeguh3hw==; Original-Received: from [87.69.77.57] (port=1625 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmK1D-0006d9-1i; Sun, 14 Nov 2021 13:14:19 -0500 In-Reply-To: <878rxq62qt.fsf@gnus.org> (message from Lars Ingebrigtsen on Sun, 14 Nov 2021 18:55:38 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:219993 Archived-At: > From: Lars Ingebrigtsen > Cc: "Feng Shu" , 51821@debbugs.gnu.org > Date: Sun, 14 Nov 2021 18:55:38 +0100 > > Eli Zaretskii writes: > > > So what would be the correct interpretation of the line-height > > variable or frame parameter, when different faces are being used? > > I think... a natural interpretation would be that explicit :height > specs would override the line-height variable/parameter? But line-height is not a variable or parameter, it is just a text property, and it needs to be put on a newline to change the height of that single line. So currently this is up to the Lisp program: if it puts this property on some line, the visual results is its responsibility. By contrast, a buffer-local variable or a frame parameter are global: they apply to all lines, tall and small alike. And users will use this variable/parameter globally as well. Thus its effect on lines that use smaller fonts is something to be concerned about. My impression is that this is wanted only for the default face, and then only for the ASCII font of that face. That could be done, I think, but (a) it will probably not work with text-scaling and other remappings of the default faces, and (b) some faces other than default also need this, definitely the mode-line and header-line, but also fixed-pitch perhaps? So I'm stuck trying to figure out what exactly are the requirements here.