From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#52888: 29.0.50; font_{delete_unmatched,score} do not handle nil FONT_WEIGHT_INDEX Date: Thu, 13 Jan 2022 08:52:22 +0200 Message-ID: <83k0f43z6h.fsf@gnu.org> References: <87czl55skc.fsf@melete.silentflame.com> <83a6g982tt.fsf@gnu.org> <87pmp4d9bv.fsf@melete.silentflame.com> <83k0f557f7.fsf@gnu.org> <87pmow1vjm.fsf@athena.silentflame.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27248"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 52888@debbugs.gnu.org To: Sean Whitton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 13 07:57:46 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n7u3O-0006yA-BR for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Jan 2022 07:57:46 +0100 Original-Received: from localhost ([::1]:35424 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n7u3M-0000lv-Gd for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Jan 2022 01:57:44 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:35112) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7tzn-0000fh-Iv for bug-gnu-emacs@gnu.org; Thu, 13 Jan 2022 01:54:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38691) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n7tzm-0000p4-NY for bug-gnu-emacs@gnu.org; Thu, 13 Jan 2022 01:54:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n7tzl-0006qA-Lz for bug-gnu-emacs@gnu.org; Thu, 13 Jan 2022 01:54:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Jan 2022 06:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52888 X-GNU-PR-Package: emacs Original-Received: via spool by 52888-submit@debbugs.gnu.org id=B52888.164205678626214 (code B ref 52888); Thu, 13 Jan 2022 06:54:01 +0000 Original-Received: (at 52888) by debbugs.gnu.org; 13 Jan 2022 06:53:06 +0000 Original-Received: from localhost ([127.0.0.1]:59827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7tyr-0006oj-NB for submit@debbugs.gnu.org; Thu, 13 Jan 2022 01:53:06 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34074) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7tyq-0006o9-8p for 52888@debbugs.gnu.org; Thu, 13 Jan 2022 01:53:04 -0500 Original-Received: from [2001:470:142:3::e] (port=38346 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7tyi-0000hF-4U; Thu, 13 Jan 2022 01:52:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Cjg3OLBdnzP4ia6htPQBIHSu9Lx2wEkmaa9EcMSMfKA=; b=h68IwDhMPt1T 38AM8ixVhaa98QepZGHiAu1IyK55CJW2K+uvvUykTkPk3d0udcUkZyhIMmSXoZIsCBlbS7EFdPEUH 8NFjH0y7E7GMu99VzI9yiACPMtmfRs1KfR/9DxG5WvU4aLRHjHbuYT1hEkvry4pQ3gyvKntBlbxMo xGV3GpK3RzilCsdgBtrExJrZP3VW8p6XRo32gPG9A7RXGHDkhtxqGPlE3Q/WRIqAy1orGJdX83cBL RiBpCofGiPB9pWvhOwF/aSd1KynBzxDqq/lozcPytXRz4N5NcdbOu+n9noRFOtG2eRxzNFaN/ZNWd jRjpPKPG7HPU3/FRZ+2N9A==; Original-Received: from [87.69.77.57] (port=4633 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7tyD-0002T7-8o; Thu, 13 Jan 2022 01:52:45 -0500 In-Reply-To: <87pmow1vjm.fsf@athena.silentflame.com> (message from Sean Whitton on Wed, 12 Jan 2022 14:41:33 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:224062 Archived-At: > From: Sean Whitton > Cc: 52888@debbugs.gnu.org > Date: Wed, 12 Jan 2022 14:41:33 -0700 > > Hello, > > On Wed 12 Jan 2022 at 04:56pm +02, Eli Zaretskii wrote: > > >> From: Sean Whitton > >> Cc: 52888@debbugs.gnu.org > >> Date: Thu, 06 Jan 2022 11:10:12 -0700 > >> > >> > OK, but (a) we need a comment there explaining why FC_VARIABLE is used > >> > as the condition, and (b) we'd also need to merge the temporary fix in > >> > font.c to master. > >> > >> Here's an updated patch. I don't think I can help with (b) but let me > >> know if there's something I can do. > > > > Thanks, I installed this, and also installed a followup change that is > > the "temporary fix" from emacs-28 adapted to the code on master. > > Thank you for reviewing and installing. > > The temporary fix can't do any harm, I suppose, but it is not clear to > me why it is necessary -- fontconfig doesn't generate the virtual/meta > FcPatterns in versions older than 2.12.91. Sorry if I didn't make that > clearer earlier, or if I am missing some other reason why it is > necessary. Yes, you should have said that earlier. But the defensive programming in that place cannot hurt, so I will leave it there.