From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56682: Fix the long lines font locking related slowdowns Date: Sat, 30 Jul 2022 14:32:25 +0300 Message-ID: <83k07u6dkm.fsf@gnu.org> References: <837d46mjen.fsf@gnu.org> <8a3eaeef01be5bfaa5ef@heytings.org> <05388e8d8812bfa3695d@heytings.org> <83v8rf5894.fsf@gnu.org> <65cb7c73fd4a999cca00@heytings.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3924"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56682@debbugs.gnu.org, monnier@iro.umontreal.ca To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 30 13:33:23 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oHkie-0000ou-Ju for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 30 Jul 2022 13:33:20 +0200 Original-Received: from localhost ([::1]:44878 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oHkid-0001DL-Ag for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 30 Jul 2022 07:33:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50582) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oHkiM-0001D5-SW for bug-gnu-emacs@gnu.org; Sat, 30 Jul 2022 07:33:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44414) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oHkiM-00025P-Ix for bug-gnu-emacs@gnu.org; Sat, 30 Jul 2022 07:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oHkiM-0000Uo-Ex for bug-gnu-emacs@gnu.org; Sat, 30 Jul 2022 07:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Jul 2022 11:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56682 X-GNU-PR-Package: emacs Original-Received: via spool by 56682-submit@debbugs.gnu.org id=B56682.16591807651882 (code B ref 56682); Sat, 30 Jul 2022 11:33:02 +0000 Original-Received: (at 56682) by debbugs.gnu.org; 30 Jul 2022 11:32:45 +0000 Original-Received: from localhost ([127.0.0.1]:34163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oHki5-0000UI-BY for submit@debbugs.gnu.org; Sat, 30 Jul 2022 07:32:45 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37630) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oHki0-0000Ty-Iq for 56682@debbugs.gnu.org; Sat, 30 Jul 2022 07:32:44 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34524) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oHkhu-00024E-8P; Sat, 30 Jul 2022 07:32:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Em1np0WQBXIJvTiQZyLFYSl37J72mzunm/VW8tQTbms=; b=e9EM0HfUUNpU RAL1xa/p+IIAp0yQ50BiHc3rMJTlldVShlPbxkHsQxNvLi/6pTs0DeVe4Kx2iPfn+vOjNkB5e55PQ j7OPN1b3UsFZvSA/dVXUjSO+N72d0QkueL6qafB+Y0S9uT0csPU9v62PBtt8QjplkziHGYinUhjqA lXFscJNRc/SFwiL+Nqy0jLim0mS6YWvcgMsD1RqEvhTd0rnhq1e7euAFWnn7/YhEj57zpf1brs3dN mhnyx6VNsXIBGdGsDjXBPpmj9L4loOSoGOEt7Vj9vV3wG7NIPpN0zTPFcWhqI75N+6I2oMDxCdmQC geggl6CYeHwmq3Op6unAKQ==; Original-Received: from [87.69.77.57] (port=2003 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oHkht-0004DU-Jr; Sat, 30 Jul 2022 07:32:33 -0400 In-Reply-To: <65cb7c73fd4a999cca00@heytings.org> (message from Gregory Heytings on Sat, 30 Jul 2022 10:52:48 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:238253 Archived-At: > Date: Sat, 30 Jul 2022 10:52:48 +0000 > From: Gregory Heytings > cc: Stefan Monnier , 56682@debbugs.gnu.org > > By the way, while trying the above, it became clear that I forgot to > properly handle the new optional argument to narrow-to-region in > byte-compiled code. But I don't know how to do that: > > diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el > index b4954eee9f..1ecd77f751 100644 > --- a/lisp/emacs-lisp/bytecomp.el > +++ b/lisp/emacs-lisp/bytecomp.el > @@ -767,7 +767,7 @@ 121 > (byte-defop 122 0 byte-char-syntax) > (byte-defop 123 -1 byte-buffer-substring) > (byte-defop 124 -1 byte-delete-region) > -(byte-defop 125 -1 byte-narrow-to-region) > +(byte-defop 125 -2 byte-narrow-to-region) > (byte-defop 126 1 byte-widen) > (byte-defop 127 0 byte-end-of-line) > > @@ -3833,7 +3833,7 @@ setcar > (byte-defop-compiler setcdr 2) > (byte-defop-compiler buffer-substring 2) > (byte-defop-compiler delete-region 2) > -(byte-defop-compiler narrow-to-region 2) > +(byte-defop-compiler narrow-to-region 2-3) > (byte-defop-compiler (% byte-rem) 2) > (byte-defop-compiler aset 3) > > is apparently not enough, because "2-3" seems to install an > integer-or-marker-p check on the third argument, which raises a > (wrong-type-argument integer-or-marker-p nil) or (wrong-type-argument > integer-or-marker-p t) error when narrow-to-region is called from > byte-compiled code. Where's the integer-or-marker-p test installed and/or called from?