From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56815: 29.0.50; Isearch lazy-highlight highlights too much when truncate-lines is in effect Date: Tue, 02 Aug 2022 14:10:21 +0300 Message-ID: <83k07q295u.fsf@gnu.org> References: <83mtct87ti.fsf@gnu.org> <865yjhc85k.fsf@mail.linkov.net> <83fsik8o39.fsf@gnu.org> <87r124kul6.fsf@gnus.org> <86mtcrpyzs.fsf@mail.linkov.net> <83bkt77nf9.fsf@gnu.org> <83a68r7m2d.fsf@gnu.org> <837d3v7kr9.fsf@gnu.org> <86fsih5bch.fsf@mail.linkov.net> <83wnbs2nc3.fsf@gnu.org> <86y1w7bzum.fsf@mail.linkov.net> <74ddc877f180e5ccb48f@heytings.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9256"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56815@debbugs.gnu.org, larsi@gnus.org, juri@linkov.net To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 02 13:11:58 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oIpoc-0002E8-1V for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Aug 2022 13:11:58 +0200 Original-Received: from localhost ([::1]:36310 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oIpoa-0008MU-Ju for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Aug 2022 07:11:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53472) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oIpni-0007Wb-T0 for bug-gnu-emacs@gnu.org; Tue, 02 Aug 2022 07:11:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52809) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oIpni-00026e-Jf for bug-gnu-emacs@gnu.org; Tue, 02 Aug 2022 07:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oIpni-00029W-FS for bug-gnu-emacs@gnu.org; Tue, 02 Aug 2022 07:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Aug 2022 11:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56815 X-GNU-PR-Package: emacs Original-Received: via spool by 56815-submit@debbugs.gnu.org id=B56815.16594386488247 (code B ref 56815); Tue, 02 Aug 2022 11:11:02 +0000 Original-Received: (at 56815) by debbugs.gnu.org; 2 Aug 2022 11:10:48 +0000 Original-Received: from localhost ([127.0.0.1]:42557 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIpnU-00028x-3M for submit@debbugs.gnu.org; Tue, 02 Aug 2022 07:10:48 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40446) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIpnP-00028g-Mb for 56815@debbugs.gnu.org; Tue, 02 Aug 2022 07:10:46 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42820) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oIpnJ-00022I-U7; Tue, 02 Aug 2022 07:10:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=V2txCNbKue3j+bu/I1WM+w6y8Kp2REliaFH9GivIv2Y=; b=T+XhUleYhgWc IlhtCHT8Pe1PrKhMQScQ2FlRRpVskrAZ9l3EreJxcZyqVhgi69Ti6WoglLllhwWkFwGLrkzR1kVmM Z31lggvuuX9uiBdtiiAbXZjjyUr9qkUFFtwMAMt3fcqap1nKwMSZsfw1gVADeUtgf8ASXGkGVJvZh WEgZKpYI5SWZCubFTaGQLsb0/+YaLXCtQhdOniGH0k3ky7AOfiubN8dhHKg7M4EzSkY9IJ/qs98/v z2xj5Oxy3nwCM4bKpyLlyqLcqffv7C9CkP5GeKG/vxSDXRT+GJ1poU816wxj+CxkRJrLPtCqZoZEw 7tX898qutJ49WvlxtCruGg==; Original-Received: from [87.69.77.57] (port=3554 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oIpnC-0004iv-4T; Tue, 02 Aug 2022 07:10:33 -0400 In-Reply-To: <74ddc877f180e5ccb48f@heytings.org> (message from Gregory Heytings on Tue, 02 Aug 2022 07:31:16 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:238519 Archived-At: > Date: Tue, 02 Aug 2022 07:31:16 +0000 > From: Gregory Heytings > cc: Eli Zaretskii , 56815@debbugs.gnu.org, larsi@gnus.org > > > >> So if no good ideas arise that are simple enough to implement, I'm okay > >> with simply disabling isearch-lazy-highlight in such buffers, as I > >> wrote in the original bug report. (Doing that will probably require > >> exposing the "long-lines" flag to Lisp, but that's fine by me.) > > > > Exposing the "long-lines" flag to Lisp is exactly what is needed. > > > > My current plan is to run a hook when long lines are detected, in which > modes such as isearch will be free to add any function they like. I'm not sure I agree that a hook is a better interface. A hook is only useful to features that are already turned on when the hook is called; features that are turned on later will miss it. By contrast, an accessor function can be called at any time, and for an attribute that, once set remains set, I think it's a more convenient way of adapting features and packages to this condition. Or am I missing something?