From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#58877: 29.0.50; [PATCH] When killing Emacs from a client frame with no other frames, Emacs shows a useless error prompt Date: Thu, 24 Nov 2022 13:51:13 +0200 Message-ID: <83k03kwoy6.fsf@gnu.org> References: <8121efd5-77c3-0682-ce0f-6be9375dadd8@gmail.com> <83a65dhm7f.fsf@gnu.org> <13835614-c593-ba2d-5373-a9950f6f3dab@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19776"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58877@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 24 12:52:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oyAmA-0004vR-OW for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Nov 2022 12:52:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oyAlB-0004QW-Qj; Thu, 24 Nov 2022 06:51:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyAkx-00043i-Ds for bug-gnu-emacs@gnu.org; Thu, 24 Nov 2022 06:51:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oyAkx-000554-4Q for bug-gnu-emacs@gnu.org; Thu, 24 Nov 2022 06:51:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oyAkv-0000Fz-VP for bug-gnu-emacs@gnu.org; Thu, 24 Nov 2022 06:51:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Nov 2022 11:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58877 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58877-submit@debbugs.gnu.org id=B58877.1669290660978 (code B ref 58877); Thu, 24 Nov 2022 11:51:01 +0000 Original-Received: (at 58877) by debbugs.gnu.org; 24 Nov 2022 11:51:00 +0000 Original-Received: from localhost ([127.0.0.1]:57563 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyAku-0000Fi-DH for submit@debbugs.gnu.org; Thu, 24 Nov 2022 06:51:00 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42886) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyAkt-0000FT-1J for 58877@debbugs.gnu.org; Thu, 24 Nov 2022 06:50:59 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyAkn-00051V-O8; Thu, 24 Nov 2022 06:50:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=jvYKj2WE3W3HZgS2eYyzg2yhQBPj1XXdqshod3bUUig=; b=ZvGP6debpJJk h273xqS1VFV9JZYwiNwZy4G0220uyghMAuwEgikGTHr8bdxDnuA+sv10VkhzAbTsIH+6Uhj0/X3Ot werwLsYC8qBDbW8mV4uCs/aY0gFHMTUl1xSGi7X6GJiBL1KmCelVoXQ9upvZB8Xr2DZFU2u7T6Kwo avJUfzfDDp0S9LsycsfkK8QTt30ufzCaYyBDJdXtXcM/+jdzhBAB4u6yBc9RMiPcT4oijtJhmvuFZ +HI4Z13XkJOfLvnDzI2D29uuwZPD9zVFLIez33w+6dYI0eBtyl/Ys1ef0AUqhUW6k//1AicI1nMNl NlFPHtJfVNSbmLNEcxRLiw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyAkn-0004CA-6f; Thu, 24 Nov 2022 06:50:53 -0500 In-Reply-To: (message from Jim Porter on Mon, 21 Nov 2022 21:06:31 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248859 Archived-At: > Date: Mon, 21 Nov 2022 21:06:31 -0800 > From: Jim Porter > Cc: 58877@debbugs.gnu.org > > On 10/30/2022 2:14 PM, Jim Porter wrote: > > Thanks for taking a look. I had hesitated to make any big changes to > > this code since it doesn't have regression tests... > Since server.el could probably use more tests anyway, I added a few ERT > tests covering the most common use cases (see the first patch), and then > added another test for the second patch. The test in the second patch is > pretty indirect, but that's because it's testing something that normally > happens when killing Emacs; it'd be hard to kill the current Emacs > instance and still be able to check test results! This is fine with me, but please fix the typo before installing: > +(defun server-stop (&optional noframe) > + "If this Emacs process has a server communication subprocess, stop it. > +If the server is running in some other Emac process (see ^^^^