From: Eli Zaretskii <eliz@gnu.org>
To: Yuan Fu <casouri@gmail.com>
Cc: 59574-done@debbugs.gnu.org
Subject: bug#59574: 29.0.50; Emacs crashes when using tree-sitter-based mode in an empty buffer
Date: Sat, 26 Nov 2022 16:31:59 +0200 [thread overview]
Message-ID: <83k03hss68.fsf@gnu.org> (raw)
In-Reply-To: <6350D0DE-63CD-410A-AA48-56D924ED67EA@gmail.com> (message from Yuan Fu on Fri, 25 Nov 2022 19:18:09 -0800)
> From: Yuan Fu <casouri@gmail.com>
> Date: Fri, 25 Nov 2022 19:18:09 -0800
> Cc: 59574@debbugs.gnu.org
>
> > There's also something strange in treesit_record_change: when it is called
> > for the first time in a buffer which was empty and you insert one character,
> > we bypass the updating of visible_beg and visible_end fields of the Lisp
> > parser object, because XTS_PARSER (lisp_parser)->tree is NULL. But it looks
> > to me that we should still update these two fields regardless, no? Only the
> > call to treesit_tree_edit_1 needs the tree. (I thought that maybe this lack
> > of update explains the assertion, but even if I move the condition to guard
> > only treesit_tree_edit_1, the assertion still happens, so I guess my
> > hypothesis eats dust.)
>
> We don’t need to update visible_beg/end in treesit_record_change if tree is NULL, because visible_beg/end represents the range of buffer that the tree sees, so if there is no tree, visible_beg/end can be considered uninitialized. However you are right about needing to update visible_beg/end, but in treesit_ensure_position_synced (I renamed it to treesit_sync_visible_region): that’s where we ensure visible_beg/end equals to BUF_BEGV_BYTE/friends.
>
> The problem is we don’t update visible_beg/end for the very first parse, when tree is NULL.
>
> I also added some comments, hopefully they sufficiently explain everything.
Thanks, the problem is gone, so I'm closing the bug.
prev parent reply other threads:[~2022-11-26 14:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 15:04 bug#59574: 29.0.50; Emacs crashes when using tree-sitter-based mode in an empty buffer Eli Zaretskii
2022-11-26 3:18 ` Yuan Fu
2022-11-26 14:31 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83k03hss68.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=59574-done@debbugs.gnu.org \
--cc=casouri@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).