From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: 59920@debbugs.gnu.org
Subject: bug#59920: [PATCH] Make checkdoc warn if not using lexical-binding
Date: Sun, 11 Dec 2022 09:29:48 +0200 [thread overview]
Message-ID: <83k02yv1n7.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkmnmZAF_fHQ1C9c-0Yw6eG5mpB7gu0jc07Ta8ep9ZH5prw@mail.gmail.com> (message from Stefan Kangas on Sat, 10 Dec 2022 15:26:03 -0800)
> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Sat, 10 Dec 2022 15:26:03 -0800
> Cc: 59920@debbugs.gnu.org
>
> +(defcustom checkdoc-lexical-binding-flag t
> + "Non-nil means generate warnings if file is not using lexical binding.
> +See Info node `(elisp) Converting to Lexical Binding' for more."
> + :type 'boolean
> + :version "29.1")
Should be "30.1", I guess?
> + (checkdoc-create-error
> + "The first line should end with \"-*- lexical-binding: t -*-\""
Is this accurate? IOW, does the lexical-binding cookie have to be the
last on the first line?
Otherwise, LGTM, thanks.
next prev parent reply other threads:[~2022-12-11 7:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 10:10 bug#59920: [PATCH] Make checkdoc warn if not using lexical-binding Stefan Kangas
2022-12-09 12:25 ` Eli Zaretskii
2022-12-09 12:42 ` Stefan Kangas
2022-12-09 14:52 ` Eli Zaretskii
2022-12-10 23:26 ` Stefan Kangas
2022-12-11 7:29 ` Eli Zaretskii [this message]
2022-12-12 2:21 ` Stefan Kangas
2023-09-01 20:07 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83k02yv1n7.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=59920@debbugs.gnu.org \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).