From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60568: [FR] 30.0.50; Help buffers and function bodies for generated functions Date: Sat, 07 Jan 2023 08:55:38 +0200 Message-ID: <83k01yu93p.fsf@gnu.org> References: <87fscpifdw.fsf@localhost> <83wn61w7lc.fsf@gnu.org> <8dea9f3e0e7865d8f3c6@heytings.org> <83r0w9vzgy.fsf@gnu.org> <8dea9f3e0e8e6114ffc3@heytings.org> <83pmbtvwyr.fsf@gnu.org> <8dea9f3e0e160e17818f@heytings.org> <83mt6xvsct.fsf@gnu.org> <8dea9f3e0ea1de84c49a@heytings.org> <83cz7sw4q1.fsf@gnu.org> <371ba1d0beb0ed44a9a6@heytings.org> <371ba1d0be96347bdf60@heytings.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23296"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gregory@heytings.org, yantar92@posteo.net, 60568@debbugs.gnu.org, mardani29@yahoo.es To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 07 07:56:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pE37m-0005lo-MJ for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Jan 2023 07:56:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pE37c-0000xu-In; Sat, 07 Jan 2023 01:56:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pE37a-0000xV-Q3 for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2023 01:56:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pE37a-00086t-Hy for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2023 01:56:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pE37a-00034S-Ea for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2023 01:56:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Jan 2023 06:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60568 X-GNU-PR-Package: emacs Original-Received: via spool by 60568-submit@debbugs.gnu.org id=B60568.167307452911754 (code B ref 60568); Sat, 07 Jan 2023 06:56:02 +0000 Original-Received: (at 60568) by debbugs.gnu.org; 7 Jan 2023 06:55:29 +0000 Original-Received: from localhost ([127.0.0.1]:56332 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pE373-00033W-0q for submit@debbugs.gnu.org; Sat, 07 Jan 2023 01:55:29 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59106) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pE371-00033J-Cv for 60568@debbugs.gnu.org; Sat, 07 Jan 2023 01:55:28 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pE36v-0007wG-D5; Sat, 07 Jan 2023 01:55:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=OJJAPgM86tU2XgmRWSU+ITHL+f5osm3J7Q81NPkYCKc=; b=Fp3foI0/rqfW 0GKrHRO0/lboLFyzjm/xljs/q1iKS6mDkMDFSs6ol7KtV0QawiQGd82FIn1u+gKaseRiFXLkRgTx/ UTK2K9bOpYVv5ispa/gwjrEv/CSpr/uxDocah+DhplF+bSchqrowKArZ0q7x2el5CVvz7H09Zu6Vo sRk0YpwipuKgD73bLyirLLYVZdbqUqrcTVW33gW6cjtYsMYC6acBHV55qmVXSNha6r7dc73xW28QJ GD+R64EWsUD4r5BTt1VBdLNpfCtHrjFP1Af/Jig1pZxZA/GGRFT/X37w3x7QGMZLJ6Mtbe3xlcD2i JdZOf67YaGYLXy+fT8A+Jg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pE36s-00027m-Bk; Sat, 07 Jan 2023 01:55:18 -0500 In-Reply-To: (message from Stefan Monnier on Fri, 06 Jan 2023 19:36:04 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252767 Archived-At: > From: Stefan Monnier > Cc: 60568@debbugs.gnu.org, Eli Zaretskii , > yantar92@posteo.net, mardani29@yahoo.es > Date: Fri, 06 Jan 2023 19:36:04 -0500 > > >>>>> What about the attached patch? It seems to work well. > >>>> SGTM. With which cases did you test this? > >>>> Adding Stefan, in case he has any comments. > >> SGTM as well. > > TBH, I'm not sure this is useful anymore, if the 'definition-name' slot is > > supposed to be used for such functions (which I didn't know). WDYT? > > If you look at the code of `find-func.el` you'll see that we already > rely on heuristics, so it seems like a natural complement. > But I agree that `definition-name` is usually preferable since it's more > reliable. Still most people don't know `definition-name`, so it can > still be helpful. Maybe people will know better if definition-name would be documented.