From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#61525: 29.0.60; delete-frame will raise frames in another virtual desktop Date: Thu, 16 Feb 2023 10:10:11 +0200 Message-ID: <83k00i81zw.fsf@gnu.org> References: <835yc2c0vw.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31064"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 61525@debbugs.gnu.org, justksqsf@gmail.com To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 16 09:11:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pSZMP-0007vJ-5B for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Feb 2023 09:11:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pSZMA-0000rv-Ik; Thu, 16 Feb 2023 03:11:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSZM7-0000r3-B5 for bug-gnu-emacs@gnu.org; Thu, 16 Feb 2023 03:11:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pSZM7-00041M-26 for bug-gnu-emacs@gnu.org; Thu, 16 Feb 2023 03:11:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pSZM6-00012G-GU for bug-gnu-emacs@gnu.org; Thu, 16 Feb 2023 03:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Feb 2023 08:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61525 X-GNU-PR-Package: emacs Original-Received: via spool by 61525-submit@debbugs.gnu.org id=B61525.16765350423947 (code B ref 61525); Thu, 16 Feb 2023 08:11:02 +0000 Original-Received: (at 61525) by debbugs.gnu.org; 16 Feb 2023 08:10:42 +0000 Original-Received: from localhost ([127.0.0.1]:34775 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSZLm-00011b-Ce for submit@debbugs.gnu.org; Thu, 16 Feb 2023 03:10:42 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:38392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSZLh-00011H-0P for 61525@debbugs.gnu.org; Thu, 16 Feb 2023 03:10:40 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSZLb-0003rb-Hn; Thu, 16 Feb 2023 03:10:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=jS1r8E8FYEg1IVMNvJv+3ddOyKyc3Bo4TxyMNqWE4Zg=; b=Ud33JwPqQmhgBaDsvra4 WiL+ySmeUNCmaZaxppnBOKajet08G7FNlKda4F9OEl+G+szCwQuKwfwVw4MgJO1TQL0bdCcXI9A63 Cna56mkEHkr9JD9YUq4GK51CEqH1bBfry/vpIQrMpxDQGo06BHSWA3r7BhrVCOwBPKY5KlskKtxXW nPbqURFx/xMKNlLRD2JLHuSqo7xXjv3mEF/bMSSBDkjXR7E3nP40T6bkQ+urtR7tccpTjjf1YEGEi k+fF5GHgdRKpxMC2Evpib5RTJZxL5aVvXhf977E1QN0juZOf4bgY1RjvUUQSr+cuidUmff9JjPi1t y2ed/UkgL2CBBg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSZLY-0004v5-KG; Thu, 16 Feb 2023 03:10:31 -0500 In-Reply-To: (message from Daniel =?UTF-8?Q?Mart=C3=ADn?= on Thu, 16 Feb 2023 00:48:59 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255797 Archived-At: > From: Daniel Martín > Cc: 61525@debbugs.gnu.org, justksqsf@gmail.com > Date: Thu, 16 Feb 2023 00:48:59 +0100 > > Eli Zaretskii writes: > > >> +void ns_make_frame_key_window (struct frame *f) > >> +{ > >> + [[FRAME_NS_VIEW (f) window] makeKeyWindow]; > >> +} > > > > Is this new call guaranteed to exist and work well on all the > > supported OS versions where we have the NS build? I wouldn't want to > > fix this on some systems and break it on others at the same time. > > makeKeyWindow is a very old API that should be available on every macOS > and GNUstep we support, AFAIK. I see usages of that API in other parts > of the NS build, in things as central as frame creation, and they are > not protected by any version or system check. Does this include the behavior? That is, does that call behave the same on all those versions? > I don't know the reason why the NS build has been calling raise-frame > for so long. I presume it was considered a good enough way to refocus > to another frame after closing one, in a world where virtual desktops > were not very common and the behavior reported by the OP was ignored. Did you try looking at Git history for this code? Maybe the log messages of the relevant commits and/or bug reports and/or discussions on emacs-devel around the dates of the commits tell something about the reasons? I've seen too many cases where changing old code introduced regressions because some aspect of the behavior was disregarded, and would like to avoid that, certainly if this is for the release branch. Thanks.