From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62720: 29.0.60; Not easy at all to upgrade :core packages like Eglot Date: Thu, 13 Apr 2023 18:56:08 +0300 Message-ID: <83jzyf4vzb.fsf@gnu.org> References: <87a5zj2vfo.fsf@gmail.com> <83sfd5761f.fsf@gnu.org> <87zg7djrgr.fsf@gmail.com> <83o7nt73za.fsf@gnu.org> <83mt3d73c2.fsf@gnu.org> <87r0sptinq.fsf@posteo.net> <83jzyh706c.fsf@gnu.org> <875ya1tdwf.fsf@posteo.net> <83edop6sdy.fsf@gnu.org> <831qkp6o0i.fsf@gnu.org> <83wn2h5825.fsf@gnu.org> <87wn2gkhzr.fsf@posteo.net> <83cz485oxi.fsf@gnu.org> <87leiwdyff.fsf@posteo.net> <834jpk5hih.fsf@gnu.org> <871qkom3fj.fsf@posteo.net> <83mt3b4yfc.fsf@gnu.org> <87edonlsxi.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35439"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 62720@debbugs.gnu.org, joaotavora@gmail.com, monnier@iro.umontreal.ca To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 13 17:56:39 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pmzJP-00091Q-CH for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Apr 2023 17:56:39 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pmzIu-0006kf-9D; Thu, 13 Apr 2023 11:56:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pmzIo-0006k4-PN for bug-gnu-emacs@gnu.org; Thu, 13 Apr 2023 11:56:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pmzIo-0006oE-GZ for bug-gnu-emacs@gnu.org; Thu, 13 Apr 2023 11:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pmzIo-0008IY-3D for bug-gnu-emacs@gnu.org; Thu, 13 Apr 2023 11:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Apr 2023 15:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62720 X-GNU-PR-Package: emacs Original-Received: via spool by 62720-submit@debbugs.gnu.org id=B62720.168140134631865 (code B ref 62720); Thu, 13 Apr 2023 15:56:02 +0000 Original-Received: (at 62720) by debbugs.gnu.org; 13 Apr 2023 15:55:46 +0000 Original-Received: from localhost ([127.0.0.1]:44482 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pmzIX-0008Hn-5c for submit@debbugs.gnu.org; Thu, 13 Apr 2023 11:55:46 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57336) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pmzIH-0008HC-Ds for 62720@debbugs.gnu.org; Thu, 13 Apr 2023 11:55:41 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pmzIA-0006bV-AM; Thu, 13 Apr 2023 11:55:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=lYSJS4nuocBuJaI0bd9KgyDCVsyR1j3rRFHV1q6wxKA=; b=l/2Q3niD6DZaIz/8Xlrk Pj6/09panl81eIwhhFRFqOynOAcoSgOggiNDZtr2q/a7I6b2HfOjsfnWbh1d8fq2imM/O4T0zgePW E1vlwcQ8rbhXHIBqMncsvw9kGaU7UqPr7qNlup2Doy/4o4rL9GSKIvvIrv2FolLDbQ9yi/SQ2zci9 2TbPYTuz5Vpwn1c/Z4pDWtEZfPg/3Bn8cnQsToHGQ/A97myDTKNbGbKUnWdfUimDJBkn4Dqsl3/1W XfGyYJOIra84tkf6CWoc7hu3JdpmuZF5DjnbBuh+rXR++ETK8zPk3St/QBe7RvQB9fEmtH5Si3+9/ mP6OfvXJOiGLvQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pmzI9-0007Vd-Qd; Thu, 13 Apr 2023 11:55:22 -0400 In-Reply-To: <87edonlsxi.fsf@posteo.net> (message from Philip Kaludercic on Thu, 13 Apr 2023 15:10:01 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259864 Archived-At: > From: Philip Kaludercic > Cc: joaotavora@gmail.com, monnier@iro.umontreal.ca, 62720@debbugs.gnu.org, > larsi@gnus.org > Date: Thu, 13 Apr 2023 15:10:01 +0000 > > Eli Zaretskii writes: > > >> The issue here is that this breaks the non-interactive invocations like > >> (package-install 'eglot), unless they invoke the function while binding > >> `current-prefix-arg', which I don't think is a common practice. > > > > Then let's add another optional argument, and let prefix arg set it. > > Would that resolve this issue? > > That could solve it, but a user option might be more elegant. We could > set it to nil for now, and change it to non-nil for the next release. Adding an option is fine by me, as long as its default preserves previous behavior. Just to be sure we are on the same page: you suggest _both_ prefix argument and user option, where user option could be used to avoid the need for prefix argument? > >> >> Note that (package-install 'eglot) does download code, but I believe > >> >> that this is the correct approach and would align with what João > >> >> wanted. > >> > > >> > I'm not sure I follow: which code does the above download? > >> > >> I did not change any of the code that downloads anything, all this does > >> is prompt the user for built-in packages when invoked interactively with > >> a prefix argument and if package-install is invoked with a built-in > >> package, then it will switch to the ELPA version. This will not happen > >> in interactive usage, since `completing-read' is called with > >> REQUIRE-MATCH. > > > > So you are saying that non-interactive calls to package-install could > > install Eglot from ELPA even without the changes, is that right? > > No, my proposed diff changes what package decides to download (the > planning phase), but doesn't touch anything after that. The current > state is that (package-install 'eglot) just prints > > ‘eglot’ is already installed And does nothing else? You seem to be saying it still downloads something, but what is that?