From: Eli Zaretskii <eliz@gnu.org>
To: Yuan Fu <casouri@gmail.com>
Cc: theo@thornhill.no, 62825@debbugs.gnu.org
Subject: bug#62825: 29.0.90; c-ts-mode doesn't recognize DEFUN functions
Date: Sun, 16 Apr 2023 11:14:25 +0300 [thread overview]
Message-ID: <83jzycb5we.fsf@gnu.org> (raw)
In-Reply-To: <80353D80-21FD-4ADE-8982-4B67C59B7E7B@gmail.com> (message from Yuan Fu on Sat, 15 Apr 2023 22:37:02 -0700)
> From: Yuan Fu <casouri@gmail.com>
> Date: Sat, 15 Apr 2023 22:37:02 -0700
> Cc: 62825@debbugs.gnu.org,
> theo@thornhill.no
>
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > Thanks. But I wonder why do we need the c-ts-mode-emacs-devel knob.
> > Why not recognize DEFUN by default everywhere? CC Mode does that,
> > AFAIK, so why shouldn't c-ts-mode do the same?
>
> I just thought the fix is a bit hacky, and does add some overhead, so
> people who don’t need it might not be happy to know that they can’t turn
> it off.
OK, but I made it into a defcustom and turned this on by default. I
also renamed a few symbols, please take a look.
Btw, should the code you added to c-ts-mode--defun-name recognize
DEFUN nodes only when this variable is non-nil?
next prev parent reply other threads:[~2023-04-16 8:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 6:44 bug#62825: 29.0.90; c-ts-mode doesn't recognize DEFUN functions Eli Zaretskii
2023-04-14 6:59 ` Eli Zaretskii
2023-04-14 20:19 ` Yuan Fu
2023-04-15 7:48 ` Eli Zaretskii
2023-04-16 5:37 ` Yuan Fu
2023-04-16 8:14 ` Eli Zaretskii [this message]
2023-04-19 19:11 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83jzycb5we.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=62825@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).