From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63949: 30.0.50; =?UTF-8?Q?`vc-print-log=C2=B4?= does not erase buffer when called from *vc-change-log* buffer, at least for CVS logs Date: Sun, 18 Jun 2023 08:35:34 +0300 Message-ID: <83jzw1pc2h.fsf@gnu.org> References: <8c62dd9a-3cad-b992-bfc4-64b2f1db4485@vodafonemail.de> <87fs729jxu.fsf@ledu-giraud.fr> <7bc0c78e-e4b5-0edc-0e9f-2f8fbafc352f@vodafonemail.de> <83y1kt180v.fsf@gnu.org> <8477db3b-b237-aa4b-b4aa-41d31cb77ac1@vodafonemail.de> <834jnf26v2.fsf@gnu.org> <83ilbvz0xx.fsf@gnu.org> <7fe39b49-8319-d7ab-99b3-afe10dc62177@vodafonemail.de> <1c00eecf-9285-3b9e-cf9f-4eba56461ae7@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37742"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63949@debbugs.gnu.org, jschmidt4gnu@vodafonemail.de To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 18 07:36:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qAl5A-0009Yo-LW for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 18 Jun 2023 07:36:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qAl52-00066V-NH; Sun, 18 Jun 2023 01:36:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAl50-00066H-IW for bug-gnu-emacs@gnu.org; Sun, 18 Jun 2023 01:36:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qAl50-000272-8r for bug-gnu-emacs@gnu.org; Sun, 18 Jun 2023 01:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qAl4z-0008Cg-SN for bug-gnu-emacs@gnu.org; Sun, 18 Jun 2023 01:36:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Jun 2023 05:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63949 X-GNU-PR-Package: emacs Original-Received: via spool by 63949-submit@debbugs.gnu.org id=B63949.168706654531511 (code B ref 63949); Sun, 18 Jun 2023 05:36:01 +0000 Original-Received: (at 63949) by debbugs.gnu.org; 18 Jun 2023 05:35:45 +0000 Original-Received: from localhost ([127.0.0.1]:52948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAl4i-0008CB-QR for submit@debbugs.gnu.org; Sun, 18 Jun 2023 01:35:45 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33954) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAl4d-0008Bu-BB for 63949@debbugs.gnu.org; Sun, 18 Jun 2023 01:35:42 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAl4X-00023O-J9; Sun, 18 Jun 2023 01:35:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=Fnp001K78UR80HI6jt936YMiMH9Gpjvh2BVWKnVy4jM=; b=QrfUXI8Q95cE3U0ylFVW sugovD8wV6R99vs4922RbFQQDZ+bCvUfjL/WK4mMpIMq+mf1xktLHptf3l4Hivdftam9F1Kgb401r qtRc/8pQAb/lnbPthZR09/arWTrhrSTGf2P2Mq+Uyd7X1n5zLKAQMxrTGd/2j0wtvBsGpzX5Wlw+u T/VmYwbDeiUk69hLS+Y5d8+GXQMR2KUdGteoXs/Jmojlcl/Pg8GbzOjXA9yVV5c+gp4pVtTLiyhXy NIXtg8DnmrbBn6eiM+2sbvmIdRLU41eOJFUytV1cwQBLIT/cBPYxS4R2GO1pA5x+u5oylvRUatcf+ C+LG7QB1zQd02g==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAl4W-0005AV-Vp; Sun, 18 Jun 2023 01:35:33 -0400 In-Reply-To: <1c00eecf-9285-3b9e-cf9f-4eba56461ae7@gutov.dev> (message from Dmitry Gutov on Sun, 18 Jun 2023 05:42:44 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263600 Archived-At: > Date: Sun, 18 Jun 2023 05:42:44 +0300 > Cc: 63949@debbugs.gnu.org > From: Dmitry Gutov > > On 16/06/2023 22:33, Jens Schmidt wrote: > > On 2023-06-10  19:23, Eli Zaretskii wrote: > > > >> I'd also like to hear Dmitry's views on these issues.  He was until > >> now silent in this discussion, AFAICT. > > > > @Dmitry: What's your view on these issues?  Just making the handling of > > VC parent buffer more documented and "more consistent", whatever that > > means, or do you prefer some particular direction? > > I think the appropriate thing here is to back out of the change that > caused the regression (d494833d47968fcd97ba549654a259d6fb6c2eee, as > we've found out) and then try to re-fix it some other way (in master?). > > Or maybe adjust the current code such as when vc-deduce-fileset-1 does > change the current buffer, vc-deduce-fileset retains that change. > > For example, using this ugly-ish (100% untested) patch: Whatever you decide, please do it soon, as I'd like to release another pretest of Emacs 29. Thanks.