From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60712: 28.2; customize-set-variable won't let you change the type of a choice Date: Sat, 22 Jul 2023 15:59:15 +0300 Message-ID: <83jzus85lo.fsf@gnu.org> References: <8d7ea0a1-0847-3643-fa8e-7bfe1e066706@gmail.com> <7daa5402-fb93-c6ba-dbd0-829eb1c4caa4@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19808"; mail-complaints-to="usenet@ciao.gmane.io" Cc: omar.antolin@gmail.com, 60712-done@debbugs.gnu.org To: Mauro Aranda Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 22 14:59:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qNCCj-00050e-Pq for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 22 Jul 2023 14:59:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qNCCS-0006o9-Jq; Sat, 22 Jul 2023 08:59:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qNCCP-0006n1-3e for bug-gnu-emacs@gnu.org; Sat, 22 Jul 2023 08:59:05 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qNCCN-0005W8-OG for bug-gnu-emacs@gnu.org; Sat, 22 Jul 2023 08:59:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qNCCM-0005pE-LJ for bug-gnu-emacs@gnu.org; Sat, 22 Jul 2023 08:59:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Jul 2023 12:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 60712 X-GNU-PR-Package: emacs Mail-Followup-To: 60712@debbugs.gnu.org, eliz@gnu.org, omar.antolin@gmail.com Original-Received: via spool by 60712-done@debbugs.gnu.org id=D60712.169003073522372 (code D ref 60712); Sat, 22 Jul 2023 12:59:02 +0000 Original-Received: (at 60712-done) by debbugs.gnu.org; 22 Jul 2023 12:58:55 +0000 Original-Received: from localhost ([127.0.0.1]:35623 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qNCCE-0005om-R8 for submit@debbugs.gnu.org; Sat, 22 Jul 2023 08:58:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36184) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qNCCE-0005oa-0H for 60712-done@debbugs.gnu.org; Sat, 22 Jul 2023 08:58:54 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qNCC8-00054y-Pd; Sat, 22 Jul 2023 08:58:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=UkK2IkTXsIczip1au55JRsiU4Kb1yIdHETP+SQe8Gxo=; b=GO4kpto23Z20cDWam5Pe rODQqYa6ax7ibqZQThrF4ZfpIHjh5NZoqlr8W3bR2iDqiGchH146MyFjWREUWivOqQhry5ugOFGE7 McoRHBI5LdZzSTnM9++fCExWGC8b0wErpI3kStKoXfTsn4eVrX796LBpgb/7nWc0R+A+8nN2O+bqW oaS+1J5NolCb+6hpIbGTJucTY+VqoavjHfUrL2MbjOANrRODGn8jKd/Tc1pIMeCyOO7Wgc1DkRH8i LoyeyJg1mtj4M4SNTYhy8f54OM+1i/R9sR1pw3XmDUVo516vPJPOxHyAc9AQXSNDeKHCJrF2cHXVx EgJSwMCaIgQoUQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qNCBw-00070j-Rx; Sat, 22 Jul 2023 08:58:39 -0400 In-Reply-To: <7daa5402-fb93-c6ba-dbd0-829eb1c4caa4@gmail.com> (message from Mauro Aranda on Sun, 16 Jul 2023 10:27:39 -0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265807 Archived-At: > Cc: Omar Antolín Camarena > Date: Sun, 16 Jul 2023 10:27:39 -0300 > From: Mauro Aranda > > Mauro Aranda writes: > > > We have this condition in widget-choice-prompt-value: > > ((and (= (length args) 2) > >       (memq old args)) > >  (if (eq old (nth 0 args)) > >      (nth 1 args) > >    (nth 0 args))) > > > > ARGS holds the choices available in the choice widget and OLD has > > the choice that matches the current value of the choice widget, before > > the user enters a new one.  This branch has been in the code since like > > forever, but I can't explain why it's good to have it. > > So, we should respect the value of widget-choice-toggle also when > prompting, of course.  I attach a patch to fix it. Thanks, installed on the master branch, and closing the bug.