unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Mauro Aranda <maurooaranda@gmail.com>
Cc: omar.antolin@gmail.com, 60712-done@debbugs.gnu.org
Subject: bug#60712: 28.2; customize-set-variable won't let you change the type of a choice
Date: Sat, 22 Jul 2023 15:59:15 +0300	[thread overview]
Message-ID: <83jzus85lo.fsf@gnu.org> (raw)
In-Reply-To: <7daa5402-fb93-c6ba-dbd0-829eb1c4caa4@gmail.com> (message from Mauro Aranda on Sun, 16 Jul 2023 10:27:39 -0300)

> Cc: Omar Antolín Camarena <omar.antolin@gmail.com>
> Date: Sun, 16 Jul 2023 10:27:39 -0300
> From: Mauro Aranda <maurooaranda@gmail.com>
> 
> Mauro Aranda <maurooaranda@gmail.com> writes:
> 
>  > We have this condition in widget-choice-prompt-value:
>  > ((and (= (length args) 2)
>  >       (memq old args))
>  >  (if (eq old (nth 0 args))
>  >      (nth 1 args)
>  >    (nth 0 args)))
>  >
>  > ARGS holds the choices available in the choice widget and OLD has
>  > the choice that matches the current value of the choice widget, before
>  > the user enters a new one.  This branch has been in the code since like
>  > forever, but I can't explain why it's good to have it.
> 
> So, we should respect the value of widget-choice-toggle also when
> prompting, of course.  I attach a patch to fix it.

Thanks, installed on the master branch, and closing the bug.





      reply	other threads:[~2023-07-22 12:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-10 17:35 bug#60712: 28.2; customize-set-variable won't let you change the type of a choice Omar Antolín Camarena
2023-07-16 12:18 ` Mauro Aranda
2023-07-16 13:27   ` Mauro Aranda
2023-07-22 12:59     ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83jzus85lo.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=60712-done@debbugs.gnu.org \
    --cc=maurooaranda@gmail.com \
    --cc=omar.antolin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).