From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65017: 29.1; Byte compiler interaction with cl-lib function objects, removes symbol-function Date: Fri, 04 Aug 2023 18:22:29 +0300 Message-ID: <83jzuavnm2.fsf@gnu.org> References: <8B08E514-B2D5-48F5-BA90-4F5A9492F8F9@gmail.com> <83r0oivr7v.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4491"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mattias.engdegard@gmail.com, 65017@debbugs.gnu.org, monnier@iro.umontreal.ca, eric.marsden@risk-engineering.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 04 17:23:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qRwe6-0000vx-Kq for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Aug 2023 17:23:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qRwdr-0002gS-DA; Fri, 04 Aug 2023 11:23:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRwdq-0002gE-DV for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2023 11:23:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qRwdq-00024y-5R for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2023 11:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qRwdp-0002Yk-Li for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2023 11:23:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Aug 2023 15:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65017 X-GNU-PR-Package: emacs Original-Received: via spool by 65017-submit@debbugs.gnu.org id=B65017.16911625499788 (code B ref 65017); Fri, 04 Aug 2023 15:23:01 +0000 Original-Received: (at 65017) by debbugs.gnu.org; 4 Aug 2023 15:22:29 +0000 Original-Received: from localhost ([127.0.0.1]:54570 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRwdJ-0002Xn-2f for submit@debbugs.gnu.org; Fri, 04 Aug 2023 11:22:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45852) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRwdG-0002XX-6I for 65017@debbugs.gnu.org; Fri, 04 Aug 2023 11:22:27 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRwd8-0001f9-NP; Fri, 04 Aug 2023 11:22:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=1FuwMec55uIVOWoypY/qiyjulftvPsn5VZI4qgoGPLY=; b=XQq0XQRjSBhX sw/2AMOBk71wUCzYK9h/5GoRfOWo62fdoAyCBk0ZuGaIXQWoOJlC4Oq56K4rm3dpkM/3bnzjfDR6Z vrdCQgOKm4etJo0IQgBKH3F5eSksCyXdo8s8E9yNRgr864OLEk2wASTA6YLKxepeBCek/YTcRA6hk 2RFUctdAiLyH4RI1tO/BEzQySIbtmfy+xRXDt7QKpcKwI88bfW5NxZcD1qKN07ogPlWNkG/VhzVW0 wZPqECZhxuRjK71Wp8vhcizBal09xiI3eKq03r4iW8lTnn1p6WNQbKe2f9SOLjfLxYML2AhMaLGLi arqLfFM5byEVcID5B9Q26g==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRwd8-0007NS-6O; Fri, 04 Aug 2023 11:22:18 -0400 In-Reply-To: (message from Alan Mackenzie on Fri, 4 Aug 2023 14:49:56 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266687 Archived-At: > Date: Fri, 4 Aug 2023 14:49:56 +0000 > Cc: monnier@iro.umontreal.ca, mattias.engdegard@gmail.com, > 65017@debbugs.gnu.org, eric.marsden@risk-engineering.org > From: Alan Mackenzie > > > > symbols-with-pos-enabled gets erroneously > > > bound to t in internal-macroexpand-for-load (emacs-lisp/macroexp.el). > > > This is the cause of the bug; in cl--labels-convert it causes the first > > > eq to return non-nil when comparing 'equal to #. > > > Why "erroneously"? what are the rules for binding that variable to a > > non-nil value? > > internal-macroexpand-for-load isn't being called in the context of a > byte compilation. It might create a symbol with position which wrongly > matches, or fails to match, another symbol. This is what has happened > in this bug. If internal-macroexpand-for-load is "verboten" from being called by the byte-compiler, I'd expect an assertion in it to that effect. Because someone, some day, might easily forget and call that function in the byte-compiler. Btw, why was this binding added there to begin with? > > I don't see any of that documented in the "Symbols with Position" node > > of the ELisp manual. > > Well, there is the sentence: "These objects are intended for use by the > byte compiler, which records in them the position of each symbol > occurrence and uses those positions in warning and error messages.". > > Do you think this should be firmed up to something like: "These objects > are for the use of the byte compiler, which records in them the position > of each symbol occurrence and uses those positions in warning and error > messages. They shouldn't normally be used otherwise."? Something like that, perhaps even stronger. And maybe an explanation what kind of problems could using them outside of the byte compiler cause. Thanks.