From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parenthesis matching Date: Sun, 17 Sep 2023 08:22:00 +0300 Message-ID: <83jzspgyrr.fsf@gnu.org> References: <127B5BEA-A24B-48A3-9827-85B7CDB67D10@secure.kjonigsen.net> <5f823f8f-d249-f4a1-71e6-083e47d0d123@gutov.dev> <83jztbeeh2.fsf@gnu.org> <03415a27-f082-b204-cece-19a9859e178d@gutov.dev> <8334zze5l4.fsf@gnu.org> <1363c54f-5109-f000-3333-78d291b2096d@gutov.dev> <2D516F0C-D7A8-49D2-8009-F911EFC55C78@secure.kjonigsen.net> <2f525ebe-74e5-dcbe-4403-5e9ae001795c@gutov.dev> <5e57b91b-2967-d82d-eca5-65dc206887cf@gutov.dev> <16E4F60E-5216-457F-A79F-F8FBB5A01D61@secure.kjonigsen.net> <6638462f-89fe-97c4-f008-27e1e2415d2b@gutov.dev> <835y4ak6hz.fsf@gnu.org> <476cebcf-68d9-254d-816c-54476046cf5e@gutov.dev> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31443"; mail-complaints-to="usenet@ciao.gmane.io" Cc: casouri@gmail.com, 65470@debbugs.gnu.org, theo@thornhill.no, jostein@secure.kjonigsen.net, monnier@iro.umontreal.ca, btuin@mailo.com, jostein@kjonigsen.net To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 17 07:23:02 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qhkFK-0007yL-62 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 17 Sep 2023 07:23:02 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qhkFG-00064A-Eh; Sun, 17 Sep 2023 01:22:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qhkFE-00063z-4h for bug-gnu-emacs@gnu.org; Sun, 17 Sep 2023 01:22:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qhkFD-00009T-1D for bug-gnu-emacs@gnu.org; Sun, 17 Sep 2023 01:22:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qhkFK-0004D6-Do for bug-gnu-emacs@gnu.org; Sun, 17 Sep 2023 01:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 Sep 2023 05:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65470 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65470-submit@debbugs.gnu.org id=B65470.169492814116135 (code B ref 65470); Sun, 17 Sep 2023 05:23:02 +0000 Original-Received: (at 65470) by debbugs.gnu.org; 17 Sep 2023 05:22:21 +0000 Original-Received: from localhost ([127.0.0.1]:48875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qhkEe-0004CA-VH for submit@debbugs.gnu.org; Sun, 17 Sep 2023 01:22:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33046) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qhkEc-0004Bx-AU for 65470@debbugs.gnu.org; Sun, 17 Sep 2023 01:22:19 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qhkEO-0008Ry-6V; Sun, 17 Sep 2023 01:22:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=vHDdk3DR3dEK5ndi70lVwJQ5BokYlNZm5iGqcYQBryg=; b=p+j/1/Kw9G9u Kk7Tqhn2uBdjMrWQ2QSur9TRC+SECPW/mFTyM6V0oBIF2DVbDDm8f4eo3kacNfatX5csBNMW1JSqe 5ajYFkYx04/Bi22RTewIer98nST8i3ef5CMZ6LhfEFH8nkedyt0Ihx6xBkkx1zw8ioqP1JFM8aOcv 3Mawz719MzprbIfi7vnIglsHhmNs8gzljFg5kn7s7nju824CNJJ89F1dKDPBeCYA4anB4ar/XuxDh 3o8rcFVJ6qCD85r4kTmvcBeM8ZCatBXu79zvZaSC9dCOzJVWnMEc7UEhYQB5MlVHmUu/byWmYW2cm VYU78j2D2aZkg+eYbEw9NA==; In-Reply-To: <476cebcf-68d9-254d-816c-54476046cf5e@gutov.dev> (message from Dmitry Gutov on Sat, 16 Sep 2023 23:05:35 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270664 Archived-At: > Date: Sat, 16 Sep 2023 23:05:35 +0300 > Cc: jostein@secure.kjonigsen.net, casouri@gmail.com, theo@thornhill.no, > jostein@kjonigsen.net, btuin@mailo.com, 65470@debbugs.gnu.org > From: Dmitry Gutov > > On 16/09/2023 16:59, Stefan Monnier wrote: > >>> No problem, pushed that to emacs-29, thanks. > >> This seems to cause: > >> > >> INFO Scraping files for loaddefs...85% > >> typescript-ts-mode:0: Warning: Not registering prefix "ts". Affects: ("tsx-ts-mode--indent-compatibility-b893426" "tsx-ts-mode--font-lock-compatibility-bb1f97b" "tsx-ts--s-p-query" "tsx-ts--syntax-propertize" "ts-ts--s-p-query" "ts-ts--syntax-propertize" "ts-ts--syntax-propertize-captures") > >> > >> Stefan, what do we usually do with such warnings? > > We usually ignored them? > > [ They only affect the features controlled by > > `help-enable-(completion-)autoload`. ] > > > > A better option, is to try and use fewer namespace prefixes. > > e.g. make sure all the definitions start with `ts-`, `ts-ts-`, > > `tsts-`, or somesuch (except for the autoloaded ones which can break > > that rule). > > > > Maybe rename `typescript-ts-mode-*` to `ts-ts-mode-*` (and > > make `typescript-ts-mode` an alias of `ts-ts-mode`). > > Thanks. I haven't seen the warnings myself, but I sorted the new > addition into two existing prefixes in that file: typescript-ts and tsx-ts. Thanks, compiles cleanly now.