From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#58396: 29.0.50; Optimization failure for add-to-list Date: Sat, 30 Sep 2023 17:26:26 +0300 Message-ID: <83jzs7aga5.fsf@gnu.org> References: <87o7uknkyx.fsf@gnus.org> <87fsfwnkl4.fsf@gnus.org> <87a663kxtz.fsf@gnus.org> <87czaygqqp.fsf@gnus.org> <87fsfte2hf.fsf@gnus.org> <87o7hod6dk.fsf@sappc2.fritz.box> <87v8bwip2h.fsf@sappc2.fritz.box> <87ttrcaqrm.fsf@sappc2.fritz.box> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18234"; mail-complaints-to="usenet@ciao.gmane.io" Cc: germanp82@hotmail.com, 58396@debbugs.gnu.org, larsi@gnus.org, monnier@iro.umontreal.ca To: Jens Schmidt Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 30 16:28:09 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qmawz-0004QF-BJ for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 30 Sep 2023 16:28:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qmawe-000431-98; Sat, 30 Sep 2023 10:27:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qmawd-00042t-9r for bug-gnu-emacs@gnu.org; Sat, 30 Sep 2023 10:27:47 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qmawd-0004wi-21 for bug-gnu-emacs@gnu.org; Sat, 30 Sep 2023 10:27:47 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qmaws-0004ru-DW for bug-gnu-emacs@gnu.org; Sat, 30 Sep 2023 10:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Sep 2023 14:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58396 X-GNU-PR-Package: emacs Original-Received: via spool by 58396-submit@debbugs.gnu.org id=B58396.169608404018645 (code B ref 58396); Sat, 30 Sep 2023 14:28:02 +0000 Original-Received: (at 58396) by debbugs.gnu.org; 30 Sep 2023 14:27:20 +0000 Original-Received: from localhost ([127.0.0.1]:59626 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qmaw7-0004qT-Rn for submit@debbugs.gnu.org; Sat, 30 Sep 2023 10:27:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54442) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qmaw3-0004q2-Vx for 58396@debbugs.gnu.org; Sat, 30 Sep 2023 10:27:14 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qmavi-0004ns-0C; Sat, 30 Sep 2023 10:26:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=63lDMkEYuWygFxpAml7jJEiPb9XG8WggxGHRR3ZC8tI=; b=G/PVbII617AY 94y7AtYiNv4bgG9xL64m/kx4+z+a7SotNtMjhqN+SyESUJP4mN5F5Uv8DXaspNGq/0qygYaxPcFdN EaJjc5XiBWU/dqVOBsYDRtLRFRcQkFS9sQSEq0Z4P2D4PimS/kpj4KI84WbHRJWqlZ39PtwMv4fSn 8z7fWM3ZjZuhfEj7HMLmhFRwBMj1jXB6XdQvkeQ0AUic9C2EdzaPg5EOgIC/vT0qSCNKR7g0NL4hS UKhvjLgp2r5k07fmoGLxtDFLC7XU4V/2VAc0cWFfmjwycgoFwAV0BUMnCtjLCWxetqFm4Hn3FTT3G N/KDRVfxzKP/gvIcUYndRw==; In-Reply-To: <87ttrcaqrm.fsf@sappc2.fritz.box> (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271545 Archived-At: > Cc: German Pacenza , 58396@debbugs.gnu.org, > Lars Ingebrigtsen > Date: Sat, 30 Sep 2023 12:39:57 +0200 > From: Jens Schmidt via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > >From cc663ccb14f3fae361733fe9742d7c7d07274d54 Mon Sep 17 00:00:00 2001 > From: Jens Schmidt > Date: Tue, 26 Sep 2023 22:26:15 +0200 > Subject: [PATCH] Silence macro expansion during completion-at-point > > * lisp/progmodes/elisp-mode.el (elisp--local-variables): Silence > messages. Suppress all errors during macro expansion. (Bug#58396) > > Do not merge to master. > --- > lisp/progmodes/elisp-mode.el | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/lisp/progmodes/elisp-mode.el b/lisp/progmodes/elisp-mode.el > index bd3916ce108..bc01058ff3c 100644 > --- a/lisp/progmodes/elisp-mode.el > +++ b/lisp/progmodes/elisp-mode.el > @@ -445,11 +445,19 @@ elisp--local-variables > (condition-case nil > (apply expander form args) > (error form)))) > + ;; Avoid any macro expansion errors when attempting > + ;; completion at point (bug#58148). As Stefan suggested > + ;; there: Silence messages [1] and suppress all errors > + ;; [3]. (Not avoiding compiler macros in the current > + ;; release branch, though.) Most of this comment should be in the commit log message, I think, and the [1] and [3] markers should be replaced with text telling what that does. Otherwise, the first patch is okay for the emacs-29 branch. Regarding the second patch: if Stefan Monnier and Stefan Kangas are okay with it, so am I. Thanks.