From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66183: elixir-ts-mode test failure Date: Thu, 05 Oct 2023 10:18:01 +0300 Message-ID: <83jzs14jx2.fsf@gnu.org> References: <87fs33wiki.fsf@pub.pink> <874jjg51mc.fsf@gmail.com> <831qeh1ba3.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28276"; mail-complaints-to="usenet@ciao.gmane.io" Cc: wkirschbaum@gmail.com, 66183@debbugs.gnu.org, jm@pub.pink To: casouri@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 05 09:19:03 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qoIdT-00076O-6t for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Oct 2023 09:19:03 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qoIdH-0003IQ-2n; Thu, 05 Oct 2023 03:18:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qoIdB-0003I3-0N for bug-gnu-emacs@gnu.org; Thu, 05 Oct 2023 03:18:45 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qoId9-0004DK-OV for bug-gnu-emacs@gnu.org; Thu, 05 Oct 2023 03:18:44 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qoIdR-0004w8-Pm for bug-gnu-emacs@gnu.org; Thu, 05 Oct 2023 03:19:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Oct 2023 07:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66183 X-GNU-PR-Package: emacs Original-Received: via spool by 66183-submit@debbugs.gnu.org id=B66183.169649030018926 (code B ref 66183); Thu, 05 Oct 2023 07:19:01 +0000 Original-Received: (at 66183) by debbugs.gnu.org; 5 Oct 2023 07:18:20 +0000 Original-Received: from localhost ([127.0.0.1]:45900 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qoIcm-0004vC-8f for submit@debbugs.gnu.org; Thu, 05 Oct 2023 03:18:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35166) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qoIck-0004uz-FZ for 66183@debbugs.gnu.org; Thu, 05 Oct 2023 03:18:19 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qoIcM-00047b-5t; Thu, 05 Oct 2023 03:17:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=fojSL1Caadxci5svdm0XJCyHJsnUaSaK9E8v46AES6w=; b=GS+NpGjGa5zcDUzMj0I8 rveIgBnHkPzBlwbHhtzLLJLntlCVIbqmQUS8XcWMcsmHWYu4yQQ9B2ZGsLmu4L7Y1MQ4moJIixGvJ V1hQYy8Xq7yzkLzc5kAQRtERuU8gyJL0qk/JXSbD2nUUw4KyDLwBYjw+YRSiUEXDCVSAzxo8y8Y2z hz4gx39qCpMAFh5o3Tc8LZts4FGi6+zYh8/lkmu2fsfDZwtxaQYbE+df8rujLNqWFMy0+iO6Qz6i8 iU1p5fvhAYWFvWDtRBLT3SkdtdsvAUGLcoUS1edoW26h/OnNO9iCP3kGo8YwACZ7KHvZVIADAEIiX z8OzK0Al3t5V4g==; In-Reply-To: <831qeh1ba3.fsf@gnu.org> (message from Eli Zaretskii on Fri, 29 Sep 2023 14:14:44 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271846 Archived-At: Ping! > Cc: wkirschbaum@gmail.com, 66183@debbugs.gnu.org, jm@pub.pink > Date: Fri, 29 Sep 2023 14:14:44 +0300 > From: Eli Zaretskii > > > Cc: 66183@debbugs.gnu.org, jm@pub.pink > > From: Yuan Fu > > Date: Tue, 26 Sep 2023 11:00:23 -0700 > > > > > On Sep 26, 2023, at 9:30 AM, Wilhelm Kirschbaum wrote: > > > > > > > > > Yuan Fu writes: > > > > > >>> On Sep 24, 2023, at 9:53 AM, john muhl via Bug reports for GNU > > >>> Emacs, the Swiss army knife of text editors > > >>> wrote: > > >>> The change in 5cba5ee8905 caused an elixir test to start failing. The > > >>> white space at the start of the test is now in a heex range so pressing > > >>> tab there matches a heex rule instead of the elixir one. Moving the > > >>> dummy range to the end fixes the test. > > >> > > >> Thank you. I’ll make sure to remember also running elixir tests when I make a change. > > >> > > >> I looked around and found elixir-mode’s language-at-point function > > >> works in a way that isn’t what tree-sitter functions > > >> expect. Tree-sitter functions expect the major mode to derive language > > >> at point by querying the host language and do some pattern matching, > > >> rather than using language parser’s range. I took a quick look at > > >> elixir’s grammar and came up with this version for a POC. You probably > > > > > > Sorry about that. I had absolutely no idea how it was expected to work. > > > > It’s absolutely my fault :-) Several people have had confusion about it, because the docstring wasn’t clear enough. I’ve updated the docstring so hopefully this confusion won’t occur in the future. > > Should this doc-string fix be cherry-picked to the release branch? > > > >