From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66390: `man' allows to inject arbitrary shell code Date: Sat, 07 Oct 2023 20:24:54 +0300 Message-ID: <83jzryz6op.fsf@gnu.org> References: <83wmvyzir2.fsf@gnu.org> <585dcaf0-358e-4a9d-84d1-6fd9c2c8aec5@gmail.com> <83v8bizf9r.fsf@gnu.org> <1865abb8-16cd-4570-9a8a-87cf9430583d@gmail.com> <875y3iigua.fsf@gmx.de> <83o7hazap7.fsf@gnu.org> <87mswugyoq.fsf@gmx.de> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17161"; mail-complaints-to="usenet@ciao.gmane.io" Cc: manikulin@gmail.com, 66390@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 07 19:25:59 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qpB3u-00049E-A9 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Oct 2023 19:25:58 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qpB3g-000654-59; Sat, 07 Oct 2023 13:25:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qpB3e-00064i-PJ for bug-gnu-emacs@gnu.org; Sat, 07 Oct 2023 13:25:42 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qpB3e-0007cF-HN for bug-gnu-emacs@gnu.org; Sat, 07 Oct 2023 13:25:42 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qpB3x-00080G-P7 for bug-gnu-emacs@gnu.org; Sat, 07 Oct 2023 13:26:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Oct 2023 17:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66390 X-GNU-PR-Package: emacs Original-Received: via spool by 66390-submit@debbugs.gnu.org id=B66390.169669951730698 (code B ref 66390); Sat, 07 Oct 2023 17:26:01 +0000 Original-Received: (at 66390) by debbugs.gnu.org; 7 Oct 2023 17:25:17 +0000 Original-Received: from localhost ([127.0.0.1]:55853 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpB3E-0007z4-Sv for submit@debbugs.gnu.org; Sat, 07 Oct 2023 13:25:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37232) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpB3D-0007yq-AV for 66390@debbugs.gnu.org; Sat, 07 Oct 2023 13:25:16 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qpB2o-0007ND-D3; Sat, 07 Oct 2023 13:24:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=WVQ9oUa87IKAx5v7LYP0EgiameK/vg1PlnfKZY9NmzA=; b=kH9TVbWmWwzE bWVD6Hp53fAATQfpCykt9dVx6HkBSdISutk2sSimziYx+WvnFyXWuCAutO6LIECQbr9UngAGl8ZeP X70jCkk6/taxGhBrO+LrPUkCmfxfuym5SxD4XtT00sC6iXIu3zH01QMtzW5Si6/PUKu+27Rb5RAWN wSeEQCFZg+OAdrTZoPikRf8n6uA412pEKeWzUjzxpPH3RFfRh9uEDNZxnvw5be7/NSlNntF8qp39O kF/1Aq9OU4bGMEky4deirByN8nS34nfbUeOOMtbNagbVKYvB5HPnB5aeVkOOnWbAB1g50kBApqbwm elj3FIqCJ2sDMVQF4+tJmQ==; In-Reply-To: <87mswugyoq.fsf@gmx.de> (message from Michael Albinus on Sat, 07 Oct 2023 18:55:01 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:272028 Archived-At: > From: Michael Albinus > Cc: manikulin@gmail.com, 66390@debbugs.gnu.org > Date: Sat, 07 Oct 2023 18:55:01 +0200 > > Eli Zaretskii writes: > > Hi Eli, > > >> The function `Man-translate-references' tries to do it. For example, it > >> translates the argument "cat(1)" into "1 cat", which doesn't pose a > >> problem. The function should check stronger, and it should reject > >> arguments like "File:\\:UserDirs(3pm)". > > > > Based on what would we reject such arguments? > > On argument syntax for man. It is documented. For what versions of 'man'? There are a lot of different versions; I myself wrote a clone, for example. > > And what kind of shell would we assume when rejecting that? > > It isn't a problem of the shell. Man-translate-references manipulates > the arguments such a way that no shell quoting is neded. Then there's no problem to begin with, since the OP claims the problem is with the shell? > > Once again, interactive invocations should let the user type whatever > > she wants, and if that fails in strange ways, it's on the user, not on > > us. > > Yes, if the user types nonsense it shall fail. The point is where to > fail. I believe it shall fail already in Man-translate-references, and > not from the man invocation with a shell. We cannot do that, unless we implement the entire behavior of 'man' in Emacs. > The docstring of man explains already, which kind of arguments are > expected. Yes, and we update that all the time, given how the systems stretch these specs. There's only madness down that road.