From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66470: 29.1; Provide Urdu input method Date: Sat, 11 Nov 2023 12:21:58 +0200 Message-ID: <83jzqowpx5.fsf@gnu.org> References: <87pm1lm23l.fsf@zohomail.eu> <87lec9m12g.fsf@zohomail.eu> <837cnpshz2.fsf@gnu.org> <877cnp1ojf.fsf@zohomail.eu> <83zg0lqxtq.fsf@gnu.org> <8734yd1mfm.fsf@zohomail.eu> <83sf6dqt33.fsf@gnu.org> <87zg0bye19.fsf@zohomail.eu> <83leblbq9e.fsf@gnu.org> <87v8apqtff.fsf@zohomail.eu> <83bkc96hg6.fsf@gnu.org> <87h6m1j3ad.fsf@zohomail.eu> <83zfzt50ni.fsf@gnu.org> <878r7diy29.fsf@zohomail.eu> <83v8ah4vmp.fsf@gnu.org> <874ji1io0t.fsf@zohomail.eu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28634"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 66470@debbugs.gnu.org To: Rahguzar Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 11 11:22:46 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r1l8W-0007ID-JG for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 11 Nov 2023 11:22:44 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r1l8A-00058T-AH; Sat, 11 Nov 2023 05:22:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r1l89-00058G-Je for bug-gnu-emacs@gnu.org; Sat, 11 Nov 2023 05:22:21 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r1l89-0003VG-Br for bug-gnu-emacs@gnu.org; Sat, 11 Nov 2023 05:22:21 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r1l8n-0004KL-Jk for bug-gnu-emacs@gnu.org; Sat, 11 Nov 2023 05:23:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 Nov 2023 10:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66470 X-GNU-PR-Package: emacs Original-Received: via spool by 66470-submit@debbugs.gnu.org id=B66470.169969816916611 (code B ref 66470); Sat, 11 Nov 2023 10:23:01 +0000 Original-Received: (at 66470) by debbugs.gnu.org; 11 Nov 2023 10:22:49 +0000 Original-Received: from localhost ([127.0.0.1]:52105 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r1l8b-0004Jr-D6 for submit@debbugs.gnu.org; Sat, 11 Nov 2023 05:22:49 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55588) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r1l8Z-0004Jf-Qp for 66470@debbugs.gnu.org; Sat, 11 Nov 2023 05:22:48 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r1l7o-0003S1-SP; Sat, 11 Nov 2023 05:22:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=7XWYe2kuyxP3RPqs0vaManAsEilQ0q7YrtdjTP8Wp8o=; b=lBGHBwWnk0bHHz0auJ8b vcmDT3UGvf65HRjGbebMXMaoKvNNbXYMte0N6Xu11pjSYLj0cPFC2HLATYz5LbUjPGPjrCkwpvbjV 1uxhs8GJYnYk1bjpmHVpiwxXPaT0wukvcp0sd9dw6QBWMpIgBWRpdECJEIQdxUTKXwnp6SSvlXRsY mLC2kqAxbSVQvAq4bokr0oetg/5PCGBYC7tUtZo6smXw/UG8YUAnGkQP94zGKjVerNIoqMkTdG83f yVMxuDF9xBBlozpE7UZGvgXY9OwOwdDO6im0nqK0uTcwOVWEVInOnFaSOTIghvRP7nncn9gLHDpq4 E3jVZayqOsp4jw==; In-Reply-To: <874ji1io0t.fsf@zohomail.eu> (message from Rahguzar on Sat, 04 Nov 2023 15:23:10 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274152 Archived-At: > From: Rahguzar > Cc: 66470@debbugs.gnu.org > Date: Sat, 04 Nov 2023 15:23:10 +0100 > > Eli Zaretskii writes: > > > Thanks. This still has a few issues, though. > > > > First, when I try to activate the pashto-keyboard input method in > > "emacs -Q", Emacs signals en error: > > > > Symbol’s value as variable is void: pakistan-urdu-use-roman-digits > > > > I wonder how this worked for you. > > I am sorry, I didn't test in a new fresh session and just evaluated the > changed code in the session I was running. I have fixed this and a more > serious issue which I didn't find for the same reason: as a result of > defvars custom initialized those values to nil instead of their standard > value. Now they are declared with a void value so that both byte > compiler and custom are happy. > > >> +(defcustom pakistan-urdu-prefixes > >> + '((diacritics "o") > >> + (poetic "G") > >> + (religious "M") > >> + (balochi-brahui "B") > >> + (pashto "P") > >> + (sindhi "C") > >> + (saraiki-hindko "X")) > >> + "Prefixes for `urdu-custom' input method." > >> + :set #'pakistan--set-prefixes > >> + :type '(repeat (list symbol string)) > >> + :group 'pakistan-urdu-input) > > > > Each defcustom should have a :version tag stating the first version in > > which it will appear. > > Thanks, I have added the version now and removed the group, since I > remembered from another thread that there preference is not to declare > the group explicitly. > > P.S. While testing this I also fixed another issue where > `pakistan--regenerate-translations` will work the first time but not > subsequent ones. The fix was to replace > > (quail-install-map `(nil)) > > (quail-install-map (list nil)) > > and I don't understand why that makes a difference. But while trying to > debug this I noticed that `quail-install-map` ignores the optional NAME > argument and always installs the map in the current quail package. Is > this the intended behavior? I have now added a > > (quail-select-package "urdu-custom") > > before the call to `quail-install-map` to make sure regenerating the > input method in custom doesn't trample some other input method. Did you forget to attach the updated patch?