From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#67764: 30.0.50; Opening image in eww no longer works Date: Sat, 16 Dec 2023 14:53:30 +0200 Message-ID: <83jzpemhpx.fsf@gnu.org> References: <87msuhfdjr.fsf@pub.pink> <87sf49ge7i.fsf@gmail.com> <83edfsvj0a.fsf@gnu.org> <87r0jst5x5.fsf@gmail.com> <87h6kn4z2q.fsf@ledu-giraud.fr> <87msufu6jf.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="585"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jm@pub.pink, 67764-done@debbugs.gnu.org, manuel@ledu-giraud.fr To: Visuwesh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 16 13:55:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rEUCI-000AQC-N0 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 16 Dec 2023 13:55:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rEUC9-00033t-MR; Sat, 16 Dec 2023 07:55:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rEUC8-00033h-A5 for bug-gnu-emacs@gnu.org; Sat, 16 Dec 2023 07:55:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rEUC6-0000iu-4B for bug-gnu-emacs@gnu.org; Sat, 16 Dec 2023 07:55:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rEUC6-0007Hf-Lp for bug-gnu-emacs@gnu.org; Sat, 16 Dec 2023 07:55:02 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Dec 2023 12:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 67764 X-GNU-PR-Package: emacs Mail-Followup-To: 67764@debbugs.gnu.org, eliz@gnu.org, jm@pub.pink Original-Received: via spool by 67764-done@debbugs.gnu.org id=D67764.170273124227904 (code D ref 67764); Sat, 16 Dec 2023 12:55:02 +0000 Original-Received: (at 67764-done) by debbugs.gnu.org; 16 Dec 2023 12:54:02 +0000 Original-Received: from localhost ([127.0.0.1]:54161 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEUB8-0007Fp-8m for submit@debbugs.gnu.org; Sat, 16 Dec 2023 07:54:02 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39222) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEUB6-0007FV-GQ for 67764-done@debbugs.gnu.org; Sat, 16 Dec 2023 07:54:01 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rEUAz-0000So-Vm; Sat, 16 Dec 2023 07:53:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=qL+3VFdLCC/s845fD7y2kgjKeI8CDp2+StTgvA4R/Fw=; b=hW7OyeoeWin6 EJAN0GigrNdkpjWJwUUhtd3T0u/6mFJPqEF8igsVlrvCco2A5hxKivm9NBRZoU1bI2hxSRZIVK3yy tt84y/us02NntsQ2gsQmlxDK7MxJNjmMGTsv9iS3Vv+PcwojXwWna9hWk6hwaw8Wq0PfGx4olN9JP 7MyVCVbvu10/BdRVnugmyS91gLiPvZCBDrD75bgmWfNCIexBet41x5IgYu28UrEz4cwwg50X9nH07 NFA5SeP4AJkT0qSjNYYEehqgAXSELGav/N/3rraxiNgQo8U22czx1s1GYChIEpZ2IZvK2INr3qo1L /XmTUA5+wUkBiCNmgSN8oA==; In-Reply-To: <87msufu6jf.fsf@gmail.com> (message from Visuwesh on Tue, 12 Dec 2023 14:44:12 +0530) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276329 Archived-At: > From: Visuwesh > Cc: Eli Zaretskii , 67764@debbugs.gnu.org, jm@pub.pink > Date: Tue, 12 Dec 2023 14:44:12 +0530 > > > Visuwesh writes: > > > > [...] > > > >> diff --git a/lisp/net/shr.el b/lisp/net/shr.el > >> index 9f030b4c743..bf5038a421d 100644 > >> --- a/lisp/net/shr.el > >> +++ b/lisp/net/shr.el > >> @@ -1137,7 +1137,9 @@ shr-put-image > >> (when image > >> ;; The trailing space can confuse shr-insert into not > >> ;; putting any space after inline images. > >> - (setq alt (string-trim alt)) > >> + ;; ALT may be nil when visiting image URLs in eww > >> + ;; (bug#6774). > > > > There is a 6 missing in the bug reference ;-) > > ...and in the commit log. I don't know how I managed to mess it up. > Thanks for catching the mistake. Revised patch attached. Thanks, installed on the master branch, and closing the bug.