From: Eli Zaretskii <eliz@gnu.org>
To: Visuwesh <visuweshm@gmail.com>
Cc: jm@pub.pink, 67764-done@debbugs.gnu.org, manuel@ledu-giraud.fr
Subject: bug#67764: 30.0.50; Opening image in eww no longer works
Date: Sat, 16 Dec 2023 14:53:30 +0200 [thread overview]
Message-ID: <83jzpemhpx.fsf@gnu.org> (raw)
In-Reply-To: <87msufu6jf.fsf@gmail.com> (message from Visuwesh on Tue, 12 Dec 2023 14:44:12 +0530)
> From: Visuwesh <visuweshm@gmail.com>
> Cc: Eli Zaretskii <eliz@gnu.org>, 67764@debbugs.gnu.org, jm@pub.pink
> Date: Tue, 12 Dec 2023 14:44:12 +0530
>
> > Visuwesh <visuweshm@gmail.com> writes:
> >
> > [...]
> >
> >> diff --git a/lisp/net/shr.el b/lisp/net/shr.el
> >> index 9f030b4c743..bf5038a421d 100644
> >> --- a/lisp/net/shr.el
> >> +++ b/lisp/net/shr.el
> >> @@ -1137,7 +1137,9 @@ shr-put-image
> >> (when image
> >> ;; The trailing space can confuse shr-insert into not
> >> ;; putting any space after inline images.
> >> - (setq alt (string-trim alt))
> >> + ;; ALT may be nil when visiting image URLs in eww
> >> + ;; (bug#6774).
> >
> > There is a 6 missing in the bug reference ;-)
>
> ...and in the commit log. I don't know how I managed to mess it up.
> Thanks for catching the mistake. Revised patch attached.
Thanks, installed on the master branch, and closing the bug.
prev parent reply other threads:[~2023-12-16 12:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 6:26 bug#67764: 30.0.50; Opening image in eww no longer works john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-11 11:40 ` Visuwesh
2023-12-11 15:03 ` john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-11 15:47 ` Eli Zaretskii
2023-12-12 4:12 ` Visuwesh
2023-12-12 8:14 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-12 9:14 ` Visuwesh
2023-12-16 12:53 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83jzpemhpx.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=67764-done@debbugs.gnu.org \
--cc=jm@pub.pink \
--cc=manuel@ledu-giraud.fr \
--cc=visuweshm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).