unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Chong Yidong <cyd@stupidchicken.com>,
	Michael Albinus <michael.albinus@gmx.de>
Cc: ofv@wanadoo.es, 7785@debbugs.gnu.org, sds@gnu.org,
	6784-done@debbugs.gnu.org
Subject: bug#7785: bug#6784: bug#7785: rgrep is broken on woe32
Date: Sun, 09 Jan 2011 19:59:56 +0200	[thread overview]
Message-ID: <83ipxyj6ub.fsf@gnu.org> (raw)
In-Reply-To: <87mxnbkt50.fsf@stupidchicken.com>

> From: Chong Yidong <cyd@stupidchicken.com>
> Cc: Sam Steingold <sds@gnu.org>, 7785@debbugs.gnu.org, 6784@debbugs.gnu.org
> Date: Sat, 08 Jan 2011 16:00:43 -0500
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > The discussions in that bug report concluded that the program file
> > name after the pipe needs to be quoted, in order for it to work with
> > file names that use forward- and back-slashes alike.  I can solve that
> > problem for rgrep (and for other similar commands) by tweaking the
> > templates used by grep.el, so as to quote the %s after the pipe
> > character `|'.  Would that be an okay solution?
> 
> I think this is an acceptable solution, and agree that changing cmdproxy
> to handle this intelligently sounds like a nightmare.

Okay, fixed in grep.el (revno 100367 on the emacs-23 branch).

> > The disadvantage is, of course, that similar solutions will have to be
> > implemented for each Emacs command that launches a shell pipeline.
> 
> Let's just fix these individually as the problems are reported.

I found only 2 more instances of this that need to be fixed.  One of
them is in jka-compr.el, where it calls `dd' in a pipe.  I fixed that
one.  The other one is in tramp.el, which uses shell pipelines a lot;
however, the only ones that need to be fixed are those that invoke
_local_ programs, not remote programs, as the latter will not be on a
Windows machine.  Michael, could you please take care of that (on the
emacs-23 branch)?  I gather that you have your master repository, so
doing it from there would be less hassle for you, and you know the
semantics of each pipeline better than I do.  Thanks.





  parent reply	other threads:[~2011-01-09 17:59 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-04 23:47 bug#7785: rgrep is broken on woe32 Sam Steingold
2011-01-05  1:05 ` Óscar Fuentes
2011-01-05 11:32   ` Eli Zaretskii
2011-01-05 20:25     ` Sam Steingold
2011-01-05 20:28       ` Sam Steingold
2011-01-05 20:50         ` Óscar Fuentes
2011-01-05 21:20           ` Sam Steingold
2011-01-05 21:26             ` Eli Zaretskii
2011-01-05 21:33             ` Eli Zaretskii
2011-01-05 22:29             ` Óscar Fuentes
2011-01-05 22:43               ` Sam Steingold
2011-01-06 12:09                 ` bug#6784: " Eli Zaretskii
2011-01-06 15:25                   ` Sam Steingold
2011-01-06 16:07                     ` Eli Zaretskii
2011-01-08 21:00                   ` bug#6784: " Chong Yidong
2011-01-08 22:13                     ` bug#7785: " Laimonas Vėbra
2011-01-09 18:07                       ` Eli Zaretskii
2011-01-09 17:59                     ` Eli Zaretskii [this message]
2011-01-09 19:56                       ` Michael Albinus
2011-01-10 20:57                       ` Michael Albinus
2011-01-05 21:19         ` Eli Zaretskii
2011-01-05 22:45           ` Sam Steingold
2011-01-05 23:49             ` Sam Steingold
2011-01-05 23:52               ` Sam Steingold
2011-01-06 10:24               ` Eli Zaretskii
2011-01-06 15:17                 ` Sam Steingold
2011-01-06 15:46                   ` Sam Steingold
2011-01-06 16:20                     ` Eli Zaretskii
2011-01-06 17:09                       ` Sam Steingold
2011-01-06 18:45                         ` Eli Zaretskii
2011-01-06 20:55                           ` Sam Steingold
2011-01-06 21:05                             ` Eli Zaretskii
2011-01-06 21:11                               ` Sam Steingold
2011-01-07  7:24                                 ` Eli Zaretskii
2011-01-07 15:16                                   ` Sam Steingold
2011-01-07 16:24                                     ` Sam Steingold
2011-01-06 16:02                   ` Eli Zaretskii
2011-01-06 16:51                     ` Sam Steingold
2011-01-06 18:48                       ` Eli Zaretskii
2011-01-06 16:04                 ` Sam Steingold
2011-01-06  9:32             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83ipxyj6ub.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=6784-done@debbugs.gnu.org \
    --cc=7785@debbugs.gnu.org \
    --cc=cyd@stupidchicken.com \
    --cc=michael.albinus@gmx.de \
    --cc=ofv@wanadoo.es \
    --cc=sds@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).