From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 12881@debbugs.gnu.org
Subject: bug#12881: Assume at least POSIX.1-1988 for fcntl.h
Date: Thu, 15 Nov 2012 19:42:51 +0200 [thread overview]
Message-ID: <83ip96u5ic.fsf@gnu.org> (raw)
In-Reply-To: <50A48C67.7020603@cs.ucla.edu>
> Date: Wed, 14 Nov 2012 22:32:07 -0800
> From: Paul Eggert <eggert@cs.ucla.edu>
> CC: 12881@debbugs.gnu.org
>
> > In several places, it actually changes the code involved
> > in dealing with the related issues. Here's one example:
>
> As far as I know, that is the only example involving O_NONBLOCK.
>
> > Here, the code that was left is identical to the one used by platforms
> > with O_NONBLOCK, but the code used by platforms with O_NDELAY was
> > different in non-trivial ways.
>
> Do those differences matter for Microsoft platforms?
I don't know, I will have to take a closer look.
> > Another potential problem is that the Windows emulation of fcntl only
> > works for sockets, whereas O_NONBLOCK is now used in other system
> > calls, like in emacs_open etc.
>
> emacs_open is the only other system call where it's used, and there it's
> used only in code that is "#ifndef DOS_NT", so it should be OK.
>
> > This patch also modifies code unrelated to O_NONBLOCK, like this one:
>
> That's OK, as this patch is about all symbols defined by fcntl.h
> in POSIX.1-1988, not just about O_NONBLOCK.
Then perhaps the problem is much smaller than I thought.
> Attached is a revised patch, relative to trunk bzr 110904,
> and with the above extra change.
Thanks, please hold on to it for a few days, until I or someone else
will have time to study it more closely.
next prev parent reply other threads:[~2012-11-15 17:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-14 7:37 bug#12881: Assume at least POSIX.1-1988 for fcntl.h Paul Eggert
2012-11-14 17:33 ` Eli Zaretskii
2012-11-15 6:32 ` Paul Eggert
2012-11-15 17:42 ` Eli Zaretskii [this message]
2012-11-15 20:07 ` Paul Eggert
2012-11-16 9:49 ` Eli Zaretskii
2012-11-16 14:37 ` Stefan Monnier
2012-11-16 14:55 ` Juanma Barranquero
2012-11-16 15:26 ` Stefan Monnier
2012-11-16 16:00 ` Eli Zaretskii
2012-11-16 16:29 ` Juanma Barranquero
2012-11-16 17:41 ` Eli Zaretskii
2012-11-16 17:10 ` Stefan Monnier
2012-11-16 17:14 ` Juanma Barranquero
2012-11-16 17:20 ` Juanma Barranquero
2012-11-16 17:44 ` Eli Zaretskii
2012-11-16 17:52 ` Drew Adams
2012-11-17 22:17 ` Paul Eggert
2012-11-18 3:46 ` Eli Zaretskii
2012-11-18 4:41 ` Paul Eggert
2012-11-18 16:58 ` Eli Zaretskii
2012-11-16 4:38 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ip96u5ic.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=12881@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).