From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#13553: 24.3.50; incorrect usage of IS_DIRECTORY_SEP Date: Sat, 26 Jan 2013 15:23:02 +0200 Message-ID: <83ip6kjcy1.fsf@gnu.org> References: <83obgcjisd.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1359206632 13489 80.91.229.3 (26 Jan 2013 13:23:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 26 Jan 2013 13:23:52 +0000 (UTC) Cc: 13553@debbugs.gnu.org, shigeru.fukaya@gmail.com To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 26 14:24:11 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Tz5jv-0008Us-2f for geb-bug-gnu-emacs@m.gmane.org; Sat, 26 Jan 2013 14:24:11 +0100 Original-Received: from localhost ([::1]:47611 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tz5jd-0003uY-02 for geb-bug-gnu-emacs@m.gmane.org; Sat, 26 Jan 2013 08:23:53 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:37674) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tz5jY-0003uT-Vv for bug-gnu-emacs@gnu.org; Sat, 26 Jan 2013 08:23:50 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tz5jY-0000Oh-08 for bug-gnu-emacs@gnu.org; Sat, 26 Jan 2013 08:23:48 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44727) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tz5jX-0000Ob-TZ for bug-gnu-emacs@gnu.org; Sat, 26 Jan 2013 08:23:47 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Tz5jl-0001EX-Gx for bug-gnu-emacs@gnu.org; Sat, 26 Jan 2013 08:24:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Jan 2013 13:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13553 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13553-submit@debbugs.gnu.org id=B13553.13592066164711 (code B ref 13553); Sat, 26 Jan 2013 13:24:01 +0000 Original-Received: (at 13553) by debbugs.gnu.org; 26 Jan 2013 13:23:36 +0000 Original-Received: from localhost ([127.0.0.1]:50191 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tz5jL-0001Dv-Ti for submit@debbugs.gnu.org; Sat, 26 Jan 2013 08:23:36 -0500 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:49154) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tz5jJ-0001Dm-84 for 13553@debbugs.gnu.org; Sat, 26 Jan 2013 08:23:34 -0500 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MH800200IB5H000@a-mtaout20.012.net.il> for 13553@debbugs.gnu.org; Sat, 26 Jan 2013 15:22:53 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MH8001N6II4VKB0@a-mtaout20.012.net.il>; Sat, 26 Jan 2013 15:22:53 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:70342 Archived-At: > From: Stefan Monnier > Cc: shigeru.fukaya@gmail.com, 13553@debbugs.gnu.org > Date: Sat, 26 Jan 2013 07:40:08 -0500 > > > You call file-attributes, which encodes the file name and passes it to > > 'lstat'. The implementation of 'lstat' in w32.c then looks at the > > last byte of the encoded file name to see if there's a slash or > > backslash there. Boom! > > I see. So, does that meant that w32.c can't faithfully implement lstat > without doing the moral equivalent of re-decoding its argument? It can, if we limit such support to Windows codepage encodings. See the changes I made on the emacs-24 branch revisions 111194 and 111200. This will still lose if the user binds file-name-coding-system to something like shift_jis (instead of using its Windows extension cp932), but there's nothing I can do about that. I was lucky to find in Windows APIs 2 functions that can move forward and backward by DBCS characters, and that accept a codepage as their argument (i.e. do not limit support to the current system codepage). Personally, I think supporting all possible Windows codepages is good enough.