From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin Date: Fri, 20 Feb 2015 12:46:36 +0200 Message-ID: <83ioewlv1v.fsf@gnu.org> References: <821tlkhq2v.fsf@gmail.com> <83mw48lwvx.fsf@gnu.org> <82wq3cga1n.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1424429243 6637 80.91.229.3 (20 Feb 2015 10:47:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 20 Feb 2015 10:47:23 +0000 (UTC) To: 19909@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Feb 20 11:47:11 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YOl6z-00027Y-Jf for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Feb 2015 11:47:09 +0100 Original-Received: from localhost ([::1]:59832 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOl6z-0007QI-2G for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Feb 2015 05:47:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34937) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOl6v-0007PI-Uv for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 05:47:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOl6s-0004TS-OW for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 05:47:05 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:57934) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOl6s-0004TM-LX for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 05:47:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YOl6s-0004zw-CO for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 05:47:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Feb 2015 10:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.142442919119173 (code B ref -1); Fri, 20 Feb 2015 10:47:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 20 Feb 2015 10:46:31 +0000 Original-Received: from localhost ([127.0.0.1]:49174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YOl6M-0004zB-T4 for submit@debbugs.gnu.org; Fri, 20 Feb 2015 05:46:31 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:33103) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YOl6K-0004z3-Of for submit@debbugs.gnu.org; Fri, 20 Feb 2015 05:46:29 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOl6J-00043a-0O for submit@debbugs.gnu.org; Fri, 20 Feb 2015 05:46:28 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:56241) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOl6I-00043O-Tc for submit@debbugs.gnu.org; Fri, 20 Feb 2015 05:46:26 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34824) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOl6H-0007Og-U6 for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 05:46:26 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOl6E-0003z4-Mv for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 05:46:25 -0500 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:58925) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOl6E-0003yg-Es for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 05:46:22 -0500 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NK200800GJSYG00@a-mtaout20.012.net.il> for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 12:46:20 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NK2008A8GL8TA60@a-mtaout20.012.net.il> for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 12:46:20 +0200 (IST) In-reply-to: <82wq3cga1n.fsf@gmail.com> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:99639 Archived-At: > From: Robert Pluim > Date: Fri, 20 Feb 2015 11:19:16 +0100 > > Eli Zaretskii writes: > > >> From: Robert Pluim > >> Date: Fri, 20 Feb 2015 10:47:36 +0100 > >> > >> It's a combination that won't compile, so it's probably best to error > >> out during configure. > > > > Why doesn't it compile? Perhaps it's better to allow it to compile, > > than to error out. > > I guess whoever put the following in w32.h had his reasons: > > #ifdef CYGWIN > #error "w32.h is not compatible with Cygwin" > #endif According to the comment in w32notify.c, w32.h is included only for w32_strerror. Could you try commenting out the w32.h inclusion, and instead copy the w32_strerror prototype into w32notify.c? Does Emacs compile then as part of the Cygwin-w32 build, and do file notifications work? (I don't have Cygwin installed to try that, sorry.) If getting the prototype of w32_strerror is the only problem, then it's easy to solve in a way that will be compatible with the Cygwin-w32 build. Thanks.