From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#21020: 24.4; `display-time-world' tampers with TZ Date: Sun, 26 Jul 2015 21:21:36 +0300 Message-ID: <83io96zsnj.fsf@gnu.org> References: <55B487B4.7060709@cs.ucla.edu> <83vbd7yny9.fsf@gnu.org> <55B51362.2010301@cs.ucla.edu> <83lhe2zuu9.fsf@gnu.org> <55B51F1A.2000100@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1437934952 6457 80.91.229.3 (26 Jul 2015 18:22:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 26 Jul 2015 18:22:32 +0000 (UTC) Cc: 21020@debbugs.gnu.org, wgg2@member.fsf.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 26 20:22:20 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZJQYw-0008J9-Rf for geb-bug-gnu-emacs@m.gmane.org; Sun, 26 Jul 2015 20:22:15 +0200 Original-Received: from localhost ([::1]:50681 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJQYq-0007wv-VZ for geb-bug-gnu-emacs@m.gmane.org; Sun, 26 Jul 2015 14:22:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36587) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJQYn-0007wm-Ex for bug-gnu-emacs@gnu.org; Sun, 26 Jul 2015 14:22:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZJQYk-00082C-3z for bug-gnu-emacs@gnu.org; Sun, 26 Jul 2015 14:22:05 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:57950) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJQYk-000823-0k for bug-gnu-emacs@gnu.org; Sun, 26 Jul 2015 14:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZJQYj-0006WL-NQ for bug-gnu-emacs@gnu.org; Sun, 26 Jul 2015 14:22:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Jul 2015 18:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21020 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 21020-submit@debbugs.gnu.org id=B21020.143793491325048 (code B ref 21020); Sun, 26 Jul 2015 18:22:01 +0000 Original-Received: (at 21020) by debbugs.gnu.org; 26 Jul 2015 18:21:53 +0000 Original-Received: from localhost ([127.0.0.1]:59396 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZJQYa-0006Vv-C2 for submit@debbugs.gnu.org; Sun, 26 Jul 2015 14:21:52 -0400 Original-Received: from mtaout28.012.net.il ([80.179.55.184]:38763) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZJQYW-0006Vl-V9 for 21020@debbugs.gnu.org; Sun, 26 Jul 2015 14:21:50 -0400 Original-Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0NS300I00X4MJP00@mtaout28.012.net.il> for 21020@debbugs.gnu.org; Sun, 26 Jul 2015 21:21:51 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NS300JA7XOF5D10@mtaout28.012.net.il>; Sun, 26 Jul 2015 21:21:51 +0300 (IDT) In-reply-to: <55B51F1A.2000100@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:105142 Archived-At: > Date: Sun, 26 Jul 2015 10:55:38 -0700 > From: Paul Eggert > CC: wgg2@member.fsf.org, 21020@debbugs.gnu.org > > Eli Zaretskii wrote: > > >> test/automated/icalender-tests.el exercises the new code. > > > > But the tests there that play with TZ are all expected failures on > > MS-Windows, because they use Posix format of time-zone definition that > > Windows runtime doesn't support. So that probably means there are no > > tests that could be used on Windows. > > OK, didn't know that. Presumably this could be addressed by adding tests for > MS-Windows TZ settings, if somebody has the time for this (pun intended...). MS-Windows supports only the simplest TZ format, as in EST-5EDT, you cannot tell it when the DST rules begin and end. And those test exercise precisely those begin/end rules that cannot work. > >> Also, the MS-Windows port can't entirely skip the time module any > >> more, as that module arranges for time.h to declare localtime_rz and > >> friends. > > > > This could conflict with time.h in nt/inc/sys/, no? > > I don't see why. is a different API. This patch affects only > . > > >lib/time.h seems to want to replace 'localtime', which might > > clash with 'sys_localtime' we currently use as replacement on w32. > > The replacement is conditional, and the condition should be false on w32. Then I guess we are lucky, and nothing could possibly become broken. Thanks.