From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#28349: 26.0.50; compilation mode syntax highlighting incorrect Date: Mon, 11 Sep 2017 19:56:50 +0300 Message-ID: <83ingprx65.fsf@gnu.org> References: <834lsh2mke.fsf@gnu.org> <83o9qjvjb0.fsf@gnu.org> <87bmmi8o6i.fsf@bapiya> <83r2vetk6c.fsf@gnu.org> <83377tthfd.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1505149114 26777 195.159.176.226 (11 Sep 2017 16:58:34 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 11 Sep 2017 16:58:34 +0000 (UTC) Cc: 28349@debbugs.gnu.org, tom@tromey.com To: Richard Copley Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 11 18:58:29 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1drS2A-0005Ve-Ap for geb-bug-gnu-emacs@m.gmane.org; Mon, 11 Sep 2017 18:58:06 +0200 Original-Received: from localhost ([::1]:59139 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drS2E-0005VG-N5 for geb-bug-gnu-emacs@m.gmane.org; Mon, 11 Sep 2017 12:58:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56962) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drS29-0005V3-71 for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2017 12:58:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1drS26-0006Yi-6D for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2017 12:58:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53416) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1drS26-0006Ye-2G for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2017 12:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1drS25-0008Td-Pd for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2017 12:58:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Sep 2017 16:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28349 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28349-submit@debbugs.gnu.org id=B28349.150514903432530 (code B ref 28349); Mon, 11 Sep 2017 16:58:01 +0000 Original-Received: (at 28349) by debbugs.gnu.org; 11 Sep 2017 16:57:14 +0000 Original-Received: from localhost ([127.0.0.1]:33864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1drS1J-0008Sc-P6 for submit@debbugs.gnu.org; Mon, 11 Sep 2017 12:57:13 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:37315) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1drS1H-0008SP-Sa for 28349@debbugs.gnu.org; Mon, 11 Sep 2017 12:57:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1drS19-0005o4-Je for 28349@debbugs.gnu.org; Mon, 11 Sep 2017 12:57:06 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35650) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drS19-0005nw-G1; Mon, 11 Sep 2017 12:57:03 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4528 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1drS17-0006sF-Ra; Mon, 11 Sep 2017 12:57:03 -0400 In-reply-to: (message from Richard Copley on Mon, 11 Sep 2017 16:33:05 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:136795 Archived-At: > From: Richard Copley > Date: Mon, 11 Sep 2017 16:33:05 +0100 > Cc: Tom Tromey , 28349@debbugs.gnu.org > > The call to string-match clobbers the correct match data, which was > obtained just before by re-search-forward, in compilation-parse-errors. > > FYI this is not new and not related to Tom's change as far as I can see. > > In compilation-parse-errors (compile.el:1426) (upcase comments added): > > [...] > (goto-char start) > (while (re-search-forward pat end t) ;; SET MATCH-DATA > (when (setq props (compilation-error-properties ;; CLOBBER IT > file line end-line col end-col (or type 2) fmt)) > [...] > ;; USE IT Thanks. Can you post a short file which exhibits the problem under compilation-mode? I tried to use your examples in this discussion, but none of them triggers these errors, so I'm probably missing something.