unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Richard Copley <rcopley@gmail.com>
Cc: 28349@debbugs.gnu.org, tom@tromey.com
Subject: bug#28349: 26.0.50; compilation mode syntax highlighting incorrect
Date: Mon, 11 Sep 2017 19:56:50 +0300	[thread overview]
Message-ID: <83ingprx65.fsf@gnu.org> (raw)
In-Reply-To: <CAPM58oj7RwwHDeA+wjqxeF-GnPee+QvsfdROOVn5oFfQbVXg5w@mail.gmail.com> (message from Richard Copley on Mon, 11 Sep 2017 16:33:05 +0100)

> From: Richard Copley <rcopley@gmail.com>
> Date: Mon, 11 Sep 2017 16:33:05 +0100
> Cc: Tom Tromey <tom@tromey.com>, 28349@debbugs.gnu.org
> 
> The call to string-match clobbers the correct match data, which was
> obtained just before by re-search-forward, in compilation-parse-errors.
> 
> FYI this is not new and not related to Tom's change as far as I can see.
> 
> In compilation-parse-errors (compile.el:1426) (upcase comments added):
> 
> [...]
> (goto-char start)
> (while (re-search-forward pat end t) ;; SET MATCH-DATA
> (when (setq props (compilation-error-properties ;; CLOBBER IT
> file line end-line col end-col (or type 2) fmt))
> [...]
> ;; USE IT

Thanks.  Can you post a short file which exhibits the problem under
compilation-mode?  I tried to use your examples in this discussion,
but none of them triggers these errors, so I'm probably missing
something.





  reply	other threads:[~2017-09-11 16:56 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-04 19:21 bug#28349: 26.0.50; compilation mode syntax highlighting incorrect Richard Copley
2017-09-05 15:26 ` Eli Zaretskii
2017-09-09 18:05   ` Eli Zaretskii
2017-09-10 17:21     ` Tom Tromey
2017-09-10 18:33       ` Richard Copley
2017-09-10 19:42         ` Eli Zaretskii
2017-09-10 19:57           ` Richard Copley
2017-09-10 22:41             ` Richard Copley
2017-09-11 14:53               ` Eli Zaretskii
2017-09-11 15:33                 ` Richard Copley
2017-09-11 16:56                   ` Eli Zaretskii [this message]
2017-09-11 19:51                     ` Richard Copley
2017-09-16 18:30                       ` Richard Copley
2017-09-16 18:37                         ` Eli Zaretskii
2017-09-16 18:49                           ` Richard Copley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83ingprx65.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=28349@debbugs.gnu.org \
    --cc=rcopley@gmail.com \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).