unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: charles@aurox.ch (Charles A. Roelli)
Cc: 28818@debbugs.gnu.org
Subject: bug#28818: kmacro stepping: void-variable kmacro-step-edit-active
Date: Mon, 16 Oct 2017 19:38:28 +0300	[thread overview]
Message-ID: <83infff3p7.fsf@gnu.org> (raw)
In-Reply-To: <m2efq4l0em.fsf@aurox.ch> (charles@aurox.ch)

merge 18708 28818
close 28818
thanks

> Date: Sun, 15 Oct 2017 20:40:49 +0200
> From: charles@aurox.ch (Charles A. Roelli)
> CC: 28818@debbugs.gnu.org
> 
> > Does the below fix this?
> > 
> > diff --git a/lisp/kmacro.el b/lisp/kmacro.el
> > index 582a58e..4abc571 100644
> > --- a/lisp/kmacro.el
> > +++ b/lisp/kmacro.el
> > @@ -937,7 +937,7 @@ kmacro-edit-lossage
> >  
> >  ;;; Single-step editing of keyboard macros
> >  
> > -(defvar kmacro-step-edit-active)  	 ;; step-editing active
> > +(defvar kmacro-step-edit-active nil)  	 ;; step-editing active
> >  (defvar kmacro-step-edit-new-macro)  	 ;; storage for new macro
> >  (defvar kmacro-step-edit-inserting)  	 ;; inserting into macro
> >  (defvar kmacro-step-edit-appending)  	 ;; append to end of macro
> 
> Yes it does.  Thanks.

Thanks, pushed.  As a nice bonus, one more kmacro test now succeeds,
as this bug is a duplicate of bug#18708.





  reply	other threads:[~2017-10-16 16:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-13 18:36 bug#28818: kmacro stepping: void-variable kmacro-step-edit-active Charles A. Roelli
2017-10-13 19:07 ` Eli Zaretskii
2017-10-15 18:40   ` Charles A. Roelli
2017-10-16 16:38     ` Eli Zaretskii [this message]
2017-10-16 18:39       ` Charles A. Roelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83infff3p7.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=28818@debbugs.gnu.org \
    --cc=charles@aurox.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).