unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Pierre Neidhardt <ambrevar@gmail.com>
Cc: 29157@debbugs.gnu.org, npostavs@users.sourceforge.net
Subject: bug#29157: 25.3; Eshell parsing fails sometimes, e.g. "date" and "sed"
Date: Sun, 26 Nov 2017 17:53:05 +0200	[thread overview]
Message-ID: <83indx6nq6.fsf@gnu.org> (raw)
In-Reply-To: <87mv39v1p1.fsf@gmail.com> (message from Pierre Neidhardt on Sun,  26 Nov 2017 10:17:30 +0100)

> From: Pierre Neidhardt <ambrevar@gmail.com>
> Cc: npostavs@users.sourceforge.net, 29157@debbugs.gnu.org
> Date: Sun, 26 Nov 2017 10:17:30 +0100
> 
> > But the answer to that question depends on the arguments and sometimes
> > on the switches, doesn't it?  E.g., Eshell's 'rm' can delete processes
> > and buffers, and unintern symbols, in addition to deleting files.
> > What exactly it does depends on the arguments.  And if you invoke it
> > with -d switch, it will call the external program, but if you invoke
> > with -f or -i or -n, it will use the built-in.  So just given the
> > verb, I don't see how you can have that indication.
> 
> Wow, I did not know that.  This is not documented in the docstring, but
> I just saw it is mentioned in the help message.
> 
> That maybe it the root of the issue: what's the standard way of
> documenting 'eshell/*' commands?
> 
> I think both `-h' and `C-h f' should document the same thing, it's
> confusing otherwise.

Patches to that effect are welcome.

> > So you want to have an indication when there's _no_ built-in
> > implementation at all, is that it?
> 
> No.  Basically if I write "rm" in Eshell, Eshell will _always_ call
> eshell/rm.  Only afterwards it will make a call to /bin/rm, depending on
> the arguments.
> As a user, what I want to know is what Eshell will call _first_, because
> then I can know the starting point of what Eshell is going to do.
> 
> Basically, my idea is simple:
> 
> - If 'eshell/foo' exists, use some eshell-builtin face on "foo". The
> user will then know that s/he should lookup the documentation of
> eshell/foo.
> 
> - Otherwise use the normal face.  The user will then refer to the man
>   page and the like.

Well, I think you said the same thing I did, just from a different
POV.  So we are in agreement.  Feel free to work on such a feature.





  reply	other threads:[~2017-11-26 15:53 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-05 11:37 bug#29157: 25.3; Eshell parsing fails sometimes, e.g. "date" and "sed" Pierre Neidhardt
2017-11-05 13:58 ` Noam Postavsky
2017-11-05 14:16   ` Pierre Neidhardt
2017-11-23  3:13     ` Noam Postavsky
2017-11-23  6:55       ` Pierre Neidhardt
2017-11-23 12:59         ` Noam Postavsky
2017-11-23 16:26           ` Eli Zaretskii
2017-11-25 17:54             ` Pierre Neidhardt
2017-11-25 18:32               ` Michael Albinus
2017-11-25 18:35                 ` Pierre Neidhardt
2017-11-25 18:50               ` Noam Postavsky
2017-11-25 19:50                 ` Eli Zaretskii
2017-11-25 20:06                   ` Noam Postavsky
2017-11-25 20:25                     ` Eli Zaretskii
2017-11-25 21:41                       ` Noam Postavsky
2017-11-26  3:35                         ` Eli Zaretskii
2017-11-26  3:21                   ` John Wiegley
2017-11-26 15:35                     ` Eli Zaretskii
2017-11-26 21:44                       ` John Wiegley
2017-11-25 19:29               ` Eli Zaretskii
2017-11-25 19:36                 ` Pierre Neidhardt
2017-11-25 19:57                   ` Eli Zaretskii
2017-11-26  9:17                     ` Pierre Neidhardt
2017-11-26 15:53                       ` Eli Zaretskii [this message]
2017-11-26  3:21                 ` John Wiegley
2017-11-26 15:33                   ` Eli Zaretskii
2017-11-26 21:45                     ` John Wiegley
2017-11-27  3:32                       ` Eli Zaretskii
2017-12-21  8:17                         ` John Wiegley
2017-12-03 20:43         ` Noam Postavsky
2017-12-04  8:43           ` John Wiegley
2017-12-04 12:51             ` Noam Postavsky
2017-11-05 15:16   ` Andreas Schwab
2017-11-10  2:04     ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83indx6nq6.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=29157@debbugs.gnu.org \
    --cc=ambrevar@gmail.com \
    --cc=npostavs@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).